Include all trips in stopTimesForStop - #3817
Merged
Merged
Conversation
hannesj
added
!Bug
t2gran
reviewed
Jan 24, 2022
hannesj
force-pushed
the
otp2_fix_stoptimes_helper
branch
from
January 25, 2022 00:47
c84cde3 to
9e62179
Compare
leonardehrenfried
approved these changes
Jan 25, 2022
t2gran
approved these changes
Jan 25, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Previously only trips that were in patterns created from real-time updaters, or which did not contain any real-time updates were returned when fetching all stop times for the requested stop. This fixes the issue by returning trips from all patterns, and filtering the ones which were replaced by another patterin deeper in the call hierarchy.
Issue
Fixes #3816
Unit tests
None changed
Code style
✅
Documentation
None required
Changelog
The changelog file
is generated from the pull-request title, make sure the title describe the feature or issue fixed.
To exclude the PR from the changelog add
[changelog skip]in the title.