Add stairsTimeFactor to StreetEdge

[hannesj]

Summary

Currently stairs are traversed using the same speed as regular horizontal ways. This adds a specific factor which slows down stair traversal by a configurable factor

Issue

Currently traversal between two platforms in Oslo S takes less than two minutes, which is unrealistic. Much of this is due to the stairs being too quick to traverse.

Unit tests

None added (yet)

Code style

✅

Documentation

None required

Changelog

The changelog file
is generated from the pull-request title, make sure the title describe the feature or issue fixed.
To exclude the PR from the changelog add [changelog skip] in the title.

[t2gran]

We should probably not apply the elevation adjustments to stairs.

[hannesj]

We should probably not apply the elevation adjustments to stairs.

This is now done by using raw length on stairs

[optionsome]

You have to also change https://github.com/opentripplanner/OpenTripPlanner/blob/dev-2.x/src/main/java/org/opentripplanner/graph_builder/module/osm/OpenStreetMapModule.java#L1311

[optionsome]

I'm getting different duration on walk leg with and without elevation data on long outdoor stairs (https://www.openstreetmap.org/way/160560554) where I set the origin and destination to be along the stairs. Could there still be some issue with splitting stair edges or maybe I'm missing something?

[hannesj]

Could there still be some issue with splitting stair edges or maybe I'm missing something?

This seem to be covered by #3862

[flaktack]

I'm getting different duration on walk leg with and without elevation data on long outdoor stairs (https://www.openstreetmap.org/way/160560554) where I set the origin and destination to be along the stairs. Could there still be some issue with splitting stair edges or maybe I'm missing something?

There could be two related factors:

• When an edge is splitDestructivley() a StreetEdge is always created, which means that the elevation data is lost. splitNonDestructively() creates a TemporaryPartialStreetEdge which copies the elevation.
• There is an effectiveWalkFactor which is used when walking, which means that traversal time changes if elevation is used.

[hannesj]

Could there still be some issue with splitting stair edges or maybe I'm missing something?

Yes, the stairs flag was not being copied to the split edges. This should be handled now. However there are still some flags, which do not get copied, and we should check which ones should be copied.