Make sure we keep the itinerary with the least number of transfers when grouping the itineraries - #3833
Merged
Conversation
when grouping the itineraries
hannesj
force-pushed
the
otp2_keep_least_transfers
branch
from
February 4, 2022 10:49
5457023 to
1f56dbe
Compare
hannesj
marked this pull request as ready for review
February 4, 2022 10:49
optionsome
approved these changes
Feb 8, 2022
t2gran
approved these changes
Feb 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
We want to make sure we always keep the itinerary with the least number of transfers when doing a group by filter, as the cost is not always the most important factor when filtering relatively similar itineraries.
Here the direct itinerary was filtered away previously.
This is built on some commits from #3828, in order to avoid merge conflicts.
Issue
closes #3801
Unit tests
Added test for the new comparator
Code style
✅
Documentation
None required
Changelog
The changelog file
is generated from the pull-request title, make sure the title describe the feature or issue fixed.
To exclude the PR from the changelog add
[changelog skip]in the title.