Return correct heuristic values, when constrained transfers is turned on - #3841
Merged
Merged
Conversation
hannesj
added
!Bug
Contributor
Author
|
This needs an update in |
hannesj
marked this pull request as draft
January 31, 2022 21:04
hannesj
force-pushed
the
otp2_heuristic_test
branch
from
February 1, 2022 14:16
23b1210 to
6627bea
Compare
hannesj
marked this pull request as ready for review
February 1, 2022 14:24
hannesj
force-pushed
the
otp2_heuristic_test
branch
from
February 1, 2022 14:24
6627bea to
b85ab44
Compare
hannesj
commented
Feb 2, 2022
leonardehrenfried
approved these changes
Feb 3, 2022
t2gran
approved these changes
Feb 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
As described in #3835 (comment), the
Stopsimplementation ofBestNumberOfTransfersreturns an invalid number of transfers, making the path pruning excessive. This fixes the issue and adds a module test for making sure the heuristics are calculated correctly.Unit tests
Added module test for heuristics
Code style
✅
Documentation
None needed
Changelog
The changelog file
is generated from the pull-request title, make sure the title describe the feature or issue fixed.
To exclude the PR from the changelog add
[changelog skip]in the title.