Skip to content

Mode & submode filter for NeTEx Service Journeys - #3844

Merged
t2gran merged 1 commit into
opentripplanner:dev-2.xfrom
Skanetrafiken:13748_submode_filter
Feb 3, 2022
Merged

Mode & submode filter for NeTEx Service Journeys#3844
t2gran merged 1 commit into
opentripplanner:dev-2.xfrom
Skanetrafiken:13748_submode_filter

Conversation

@Bartosz-Kruba

@Bartosz-Kruba Bartosz-Kruba commented Jan 31, 2022

Copy link
Copy Markdown
Contributor

Summary

Allow filtering on servicejourney mode & submode through transmodel API.

Issue

issue

Closes #3842

@t2gran
t2gran requested a review from hannesj February 1, 2022 10:40
@t2gran t2gran added this to the 2.1 milestone Feb 1, 2022
@Bartosz-Kruba
Bartosz-Kruba force-pushed the 13748_submode_filter branch 3 times, most recently from d68c90c to 371c841 Compare February 1, 2022 15:39
@Bartosz-Kruba Bartosz-Kruba changed the title Draft for submode filter Mode & submode filter for NeTEx Service Journeys Feb 1, 2022
@Bartosz-Kruba

Bartosz-Kruba commented Feb 1, 2022

Copy link
Copy Markdown
Contributor Author

I did some locust tests based on 500 most common searches from Skånetrafiken app.

dev-2.x:

Attempt Median response time Average response time
Attempt 1 310 ms 402 ms
Attempt 2 310 ms 410 ms
Attempt 3 310 ms 412 ms

This PR:

Attempt Median response time Average response time
Attempt 1 310 ms 409 ms
Attempt 2 310 ms 409 ms
Attempt 3 330 ms 422 ms

@Bartosz-Kruba
Bartosz-Kruba marked this pull request as ready for review February 1, 2022 16:02
@Bartosz-Kruba
Bartosz-Kruba requested a review from a team as a code owner February 1, 2022 16:02
Signed-off-by: bartosz <bartosz.kruba@purplescout.se>
@t2gran t2gran added the !Improvement A functional improvement or micro feature label Feb 3, 2022
@t2gran
t2gran merged commit 392d24c into opentripplanner:dev-2.x Feb 3, 2022
t2gran pushed a commit that referenced this pull request Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

!Improvement A functional improvement or micro feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Transmodel cannot filter on service journey mode / submode

4 participants