Skip to content

Add Hungarian translation#3861

Merged
leonardehrenfried merged 8 commits into
opentripplanner:dev-2.xfrom
realCity:feature/hu-translation
Feb 17, 2022
Merged

Add Hungarian translation#3861
leonardehrenfried merged 8 commits into
opentripplanner:dev-2.xfrom
realCity:feature/hu-translation

Conversation

@flaktack

@flaktack flaktack commented Feb 4, 2022

Copy link
Copy Markdown
Contributor

Summary

This adds a Hungarian translation, along with a few translations changes:

  • the debug client translation files are regenerated, a few missing texts are enclosed with _tr()
  • Origin/Destination texts are added to internals.properties so those may also be translated
  • add LOCATION_NOT_ACCESSIBLE to Message.properties
  • correct locale date/time parameter handling in the debug client

Issue

#3840

@flaktack flaktack left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@debyos thanks for the translations. I've looked through the source code, and there were two more files: could you also create translations for these too?

Comment thread src/main/resources/Message_hu.properties
Comment thread src/main/resources/WayProperties_hu.properties Outdated
@flaktack flaktack force-pushed the feature/hu-translation branch 2 times, most recently from 6c8ee94 to aa1ae67 Compare February 4, 2022 10:36
@t2gran t2gran added this to the 2.1 milestone Feb 8, 2022
@t2gran t2gran added the !Improvement A functional improvement or micro feature label Feb 8, 2022
Comment thread src/main/resources/internals_fi.properties Outdated
@flaktack flaktack force-pushed the feature/hu-translation branch from 978db0a to 0ccc790 Compare February 15, 2022 12:07
@flaktack

Copy link
Copy Markdown
Contributor Author

I've translated the missing parts -- this is ready for review.

@flaktack flaktack marked this pull request as ready for review February 15, 2022 12:09
@flaktack flaktack requested a review from a team as a code owner February 15, 2022 12:09
@flaktack flaktack force-pushed the feature/hu-translation branch from 0ccc790 to bcdc8e2 Compare February 15, 2022 13:33
@leonardehrenfried

leonardehrenfried commented Feb 15, 2022

Copy link
Copy Markdown
Member

There a quite a few strings that now have an empty string. Will they fallback to a default locale or really show the empty string when used?

@flaktack flaktack force-pushed the feature/hu-translation branch from bcdc8e2 to 8627cfb Compare February 16, 2022 09:10
@flaktack

Copy link
Copy Markdown
Contributor Author

It will fallback to the default value if no translation exists for both the java and javascript translations. I've updated the code to remove the untranslated defaults from the property files.

Currently the Message.properties (trip planning error/status message translations) isn't used -- should I change that here or will that be fixed as part of the itinerary refactors?

Comment thread src/client/js/otp/util/Itin.js Outdated
}
},

getModeColor : function(mode) {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is probably from #3908, isn't it?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I rebased onto the wrong branch. I've removed those commits.

@leonardehrenfried leonardehrenfried merged commit 2aef238 into opentripplanner:dev-2.x Feb 17, 2022
t2gran pushed a commit that referenced this pull request Feb 17, 2022
@flaktack flaktack deleted the feature/hu-translation branch February 17, 2022 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

!Improvement A functional improvement or micro feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants