Include generalizedCost in the optimized transfers wait-time cost - #3864
Merged
t2gran merged 1 commit intoFeb 8, 2022
Merged
Conversation
hannesj
approved these changes
Feb 4, 2022
leonardehrenfried
approved these changes
Feb 8, 2022
Member
Author
|
I will do some testing today, to see how much we need to change the configuration parameters for this to continue to work in our edge cases. See #3644 for my finding later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Optimized transfer calculate a wait-time-optimized-cost for each possible combination of transfers for a given path. It does so to find the pest places to do the transfer, avoiding back travel and short transfer times. The existing implementation did not take into account the walking cost for the different transfers. In most cases this is ok, because long walking transfers leave less time to do the transfer, but not in all cases - see issue. This fixes this be just adding the generalized cost to the wait-time-optimized-cost (both have the same cost unit/scale - seconds).
NOTE! The optimized transfer service is configured and needs to be tuned again, after this PR is merged.
Issue
closes #3834
Unit tests
Updated
Code style
✅
Documentation
✅