Add support for creating constrained transfers from real-time generated patterns - #3878
Merged
hannesj merged 3 commits intoFeb 11, 2022
Merged
Conversation
hannesj
changed the title
leonardehrenfried
previously approved these changes
Feb 9, 2022
hannesj
force-pushed
the
otp2_realtime_constrained_transfers
branch
from
February 9, 2022 14:12
4c1d3c4 to
8405e27
Compare
t2gran
requested changes
Feb 9, 2022
t2gran
left a comment
t2gran
left a comment
Member
There was a problem hiding this comment.
This now looks much better, a few comments on the RT update strategy and why this is now thread safe, is all I think is needed.
t2gran
reviewed
Feb 11, 2022
…nsit/constrainedtransfer/TransferIndexGenerator.java
t2gran
approved these changes
Feb 11, 2022
leonardehrenfried
approved these changes
Feb 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add support for creating constrained transfers from real-time generated patterns.
Issue
closes #3877
Unit tests
Not updated
Code style
✅
Documentation
No changes required.
Changelog
The changelog file
is generated from the pull-request title, make sure the title describe the feature or issue fixed.
To exclude the PR from the changelog add
[changelog skip]in the title.