Skip to content

Remove ET realtime override code - #3912

Merged
MikaelJarfors merged 1 commit into
opentripplanner:dev-2.xfrom
Skanetrafiken:realtime_override_bugfix
Feb 23, 2022
Merged

Remove ET realtime override code#3912
MikaelJarfors merged 1 commit into
opentripplanner:dev-2.xfrom
Skanetrafiken:realtime_override_bugfix

Conversation

@Bartosz-Kruba

Copy link
Copy Markdown
Contributor

Summary

Ensure that OTP does not override times from SIRI ET messages.

Issue

#3909

Unit tests

This is a minor fix. No unit tests needed.

Code style

Following code style.

Documentation

This is a minor fix. No documentation needed.

- Ensure that OTP does not override times from SIRI ET messages.
@Bartosz-Kruba
Bartosz-Kruba requested a review from a team as a code owner February 18, 2022 08:35
@MikaelJarfors MikaelJarfors added the Skanetrafiken On skanetrafikens roadmap label Feb 22, 2022
@hannesj hannesj added the !Bug Apply to issues describing a bug and PRs witch fixes it. label Feb 22, 2022
@t2gran t2gran added this to the 2.1 milestone Feb 22, 2022
@t2gran
t2gran requested review from hannesj and lassetyr February 22, 2022 19:08
@t2gran

t2gran commented Feb 22, 2022

Copy link
Copy Markdown
Member

I assigned @lassetyr and @hannesj to review this - I am not able to tell if this is correct or not.

@MikaelJarfors
MikaelJarfors merged commit 2472fe0 into opentripplanner:dev-2.x Feb 23, 2022
t2gran pushed a commit that referenced this pull request Feb 23, 2022
@hannesj

hannesj commented Mar 14, 2022

Copy link
Copy Markdown
Contributor

This is causing problems for us, as none of the last stops have a realtimeDepartureTime, meaning that the trip update is skipped, if the last stop arrival has any delay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

!Bug Apply to issues describing a bug and PRs witch fixes it. Skanetrafiken On skanetrafikens roadmap

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TimetableHelper modifies real-time data before applying updates to TripTimes.

5 participants