Repository navigation
OTP support for NeTEx GroupOfLines - #3928
Merged
Bartosz-Kruba merged 1 commit intoMar 3, 2022
Merged
Bartosz-Kruba merged 1 commit into
Bartosz-Kruba merged 1 commit into
Conversation
Bartosz-Kruba
force-pushed
the
14379_groupOfLines_support
branch
3 times, most recently
from
February 24, 2022 10:59
068cb6f to
d8282a4
Compare
Bartosz-Kruba
marked this pull request as ready for review
February 24, 2022 14:03
t2gran
requested changes
Feb 25, 2022
Bartosz-Kruba
force-pushed
the
14379_groupOfLines_support
branch
2 times, most recently
from
March 1, 2022 12:24
b4499d8 to
3ee3ccf
Compare
hannesj
self-requested a review
March 1, 2022 13:31
t2gran
reviewed
Mar 2, 2022
t2gran
reviewed
Mar 2, 2022
t2gran
reviewed
Mar 2, 2022
t2gran
requested changes
Mar 2, 2022
t2gran
previously approved these changes
Mar 3, 2022
- Added mapping for GroupOfLines - Exposed GroupOfLines in Transmodel API
Bartosz-Kruba
force-pushed
the
14379_groupOfLines_support
branch
from
March 3, 2022 08:26
5c27cf3 to
62956d5
Compare
leonardehrenfried
approved these changes
Mar 3, 2022
t2gran
approved these changes
Mar 3, 2022
hannesj
reviewed
Mar 3, 2022
| SandboxAPILegacyGraphQLApi(false), | ||
| SandboxAPIMapboxVectorTilesApi(false), | ||
| SandboxAPITransmodelApi(false), | ||
| SandboxAPITransmodelApi(true), |
Contributor
There was a problem hiding this comment.
@Bartosz-Kruba I noticed this was changed. Can you do a PR to revert it. I recommend always using an otp-config-json, so that you never need to change the default values.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Issue
closes #3917
Unit tests
New unit tests for new mapping functionality:
Code style
Documentation