Remove optimize=TRANSFERS - #4004
Merged
leonardehrenfried merged 1 commit intoMar 22, 2022
Merged
Conversation
leonardehrenfried
force-pushed
the
remove-transfers
branch
2 times, most recently
from
March 18, 2022 14:29
e02f940 to
7dd847b
Compare
leonardehrenfried
changed the title
t2gran
previously approved these changes
Mar 21, 2022
optionsome
reviewed
Mar 22, 2022
leonardehrenfried
changed the title
leonardehrenfried
force-pushed
the
remove-transfers
branch
2 times, most recently
from
March 22, 2022 08:27
e9f04c4 to
1eaa0ce
Compare
leonardehrenfried
force-pushed
the
remove-transfers
branch
from
March 22, 2022 08:28
1eaa0ce to
61a2234
Compare
hannesj
approved these changes
Mar 22, 2022
t2gran
approved these changes
Mar 22, 2022
t2gran
pushed a commit
that referenced
this pull request
Mar 22, 2022
t2gran
added
the
+Skip Changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This has not worked as expected for a very long time. You should use
transferCostinstead.It is a breaking change for the Transmodel API. If you want I can make it backwards-compatible.
Issue
None
Unit tests
None
Code style
Yes
Documentation
None
Changelog
Skip