Enable GBFS floating vehicles by default

[leonardehrenfried]

Summary

The feature flag FloatingBike was introduced because linking these vehicles was buggy and the link edges were not cleaned up correctly.

This was fixed (I believe) in #3351.

For this reason we can enable this by default.

If we want to be more careful we could also just set the default to true.

Issue

none, but someone asked on the mailing list: https://groups.google.com/g/opentripplanner-users/c/cF8rKfRtrPg/m/CjvXJeJjBAAJ?utm_medium=email&utm_source=footer

Unit tests

no

Code style

yes

Documentation

yes

[optionsome]

I've seen some station based networks that also expose the vehicles. I'm not sure if exposing them always makes sense but I'm in favour of setting this to be default on but I think we could still keep the parameter. Ideally, I think the configuration should be on updater level but it's not really a requirement for us currently and if it becomes, we can add that possibility.

[hannesj]

I've seen some station based networks that also expose the vehicles. I'm not sure if exposing them always makes sense but I'm in favour of setting this to be default on but I think we could still keep the parameter. Ideally, I think the configuration should be on updater level but it's not really a requirement for us currently and if it becomes, we can add that possibility.

The mapFreeVehicleStatus only returns vehicles which are not part of any station, so that is already covered

[leonardehrenfried]

Spoke to @t2gran and he preferred to just enable the flag by default.

[optionsome]

But what if, with a network like the one in Helsinki, the user pauses the trip and leaves the vehicle somewhere (not to a station). I guess we also store and expose vehicles that are reserved?