Repository navigation
Consider Wheelchair boarding/alightning when routing from or to directly to a stop - #4046
Conversation
c96c362 to
10e5656
Compare
|
I think from a logic perspective this looks good. I'm sure that @t2gran has some comments about the general architecture though. |
|
I think the filtering might be better done in It might be sensible to add something to the |
|
Tip: As @hannesj writes passing information trough Raptor, changing the Raptor interfaces is a red flag. The interfaces define what information Raptor need to do the routing in a generic way - passing information through is possible without changing the interfaces. We try hard to avoid changing them. If a small feature like wheelchair routing can not be supported using the existing abstractions, then we think reel hard to and add a reusable abstraction/feature to Raptor. An example would be that wheelchair need extra board time depending on the trip, then we will add the ability to add extra board time to raptor - but we are not passing in a "wheelchair" flag to enable it, instead we make it pluggable. |
|
Earlier we had a stop filter in Raptor, but we removed it because we did not use it. It might be an idea to add that back for this - but I am not sure. |
10e5656 to
71496c7
Compare
71496c7 to
d075382
Compare
t2gran
left a comment
There was a problem hiding this comment.
I think this looks ok, just some minor stuff. A little confusing to find the entry point of this code, since it existed already.
d075382 to
6330602
Compare
6330602 to
ed27554
Compare
33059e2
ed27554 to
33059e2
Compare
|
We merged #4007 recently which reformatted all files in the repo. This created a conflict with this PR - sorry about that. Could you please resolve the conflicts and push an update? |
33059e2 to
92a3307
Compare
- If requested wheelchair add check if boarding and alightning allows it - Unit test RoutingRequestTransitDataProviderFilter
7199987
92a3307 to
7199987
Compare
His comments have been addressed.
Summary
If a trip search is done from a StopPoint to another and in GraphQl the parameter wheelhairAccessible is true then we find trips that should not be found because the stop is not considered accessible for wheelchair.
Issue
closes #4044
Unit tests
Unit test in Raptor module, new class following instructions in markup document. Test going between stops where one stop has no access for wheelchair.