Skip to content

Consider Wheelchair boarding/alightning when routing from or to directly to a stop - #4046

Merged
TimMickelsonSkanetrafiken merged 1 commit into
opentripplanner:dev-2.xfrom
Skanetrafiken:wheelchair_boarding
Apr 8, 2022
Merged

TimMickelsonSkanetrafiken merged 1 commit into
opentripplanner:dev-2.xfrom
Skanetrafiken:wheelchair_boarding

Conversation

@TimMickelsonSkanetrafiken

Copy link
Copy Markdown
Contributor
- If requested wheelchair trip, check on boarding/alightning if possible on stop
- Unit test Raptor wheelchair accessibility

Summary

If a trip search is done from a StopPoint to another and in GraphQl the parameter wheelhairAccessible is true then we find trips that should not be found because the stop is not considered accessible for wheelchair.

Issue

closes #4044

Unit tests

Unit test in Raptor module, new class following instructions in markup document. Test going between stops where one stop has no access for wheelchair.

@TimMickelsonSkanetrafiken
TimMickelsonSkanetrafiken requested a review from a team as a code owner March 30, 2022 11:39
@MikaelJarfors MikaelJarfors added the Skanetrafiken On skanetrafikens roadmap label Mar 30, 2022
@leonardehrenfried leonardehrenfried changed the title 15012 Consider Wheelchair boarding/alightning Consider Wheelchair boarding/alightning Mar 30, 2022
@leonardehrenfried leonardehrenfried changed the title Consider Wheelchair boarding/alightning Consider Wheelchair boarding/alightning when routing from or to directly to a stop Mar 30, 2022
@t2gran t2gran added this to the 2.2 milestone Mar 30, 2022
@leonardehrenfried

Copy link
Copy Markdown
Member

I think from a logic perspective this looks good.

I'm sure that @t2gran has some comments about the general architecture though.

@hannesj

hannesj commented Mar 31, 2022 •

Copy link
Copy Markdown
Contributor

I think the filtering might be better done in RaptorRoutingRequestTransitDataCreator, so that we lift up the boardingPossible and alightingPossible Bitsets to TripPatternForDates. That way we could do a union between those from the pattern and wheelchairAccessible, if wheelchair is required, and otherwise just use the ones from the TripPatternWithRaptorStopIndexes. This would make it easier to do other types of similar filtering in the future, such as banned stops.

It might be sensible to add something to the TransitDataProviderFilter interface for this.

@t2gran
t2gran self-requested a review March 31, 2022 13:58
@t2gran

t2gran commented Apr 1, 2022 •

Copy link
Copy Markdown
Member

Tip: As @hannesj writes passing information trough Raptor, changing the Raptor interfaces is a red flag. The interfaces define what information Raptor need to do the routing in a generic way - passing information through is possible without changing the interfaces. We try hard to avoid changing them. If a small feature like wheelchair routing can not be supported using the existing abstractions, then we think reel hard to and add a reusable abstraction/feature to Raptor. An example would be that wheelchair need extra board time depending on the trip, then we will add the ability to add extra board time to raptor - but we are not passing in a "wheelchair" flag to enable it, instead we make it pluggable.

@t2gran

t2gran commented Apr 1, 2022

Copy link
Copy Markdown
Member

Earlier we had a stop filter in Raptor, but we removed it because we did not use it. It might be an idea to add that back for this - but I am not sure.

@hannesj
hannesj marked this pull request as draft April 5, 2022 08:56
@hannesj
hannesj marked this pull request as ready for review April 5, 2022 13:58
t2gran
t2gran previously requested changes Apr 5, 2022

@t2gran t2gran left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks ok, just some minor stuff. A little confusing to find the entry point of this code, since it existed already.

Comment thread src/test/resources/mmri/2b/stops.txt
Comment thread pom.xml Outdated
@leonardehrenfried

Copy link
Copy Markdown
Member

We merged #4007 recently which reformatted all files in the repo. This created a conflict with this PR - sorry about that.

Could you please resolve the conflicts and push an update?

	- If requested wheelchair add check if boarding and alightning allows it
	- Unit test RoutingRequestTransitDataProviderFilter
@leonardehrenfried
leonardehrenfried dismissed t2gran’s stale review April 8, 2022 07:17

His comments have been addressed.

@TimMickelsonSkanetrafiken
TimMickelsonSkanetrafiken merged commit 42d07f5 into opentripplanner:dev-2.x Apr 8, 2022
t2gran pushed a commit that referenced this pull request Apr 8, 2022
@t2gran t2gran added !Improvement A functional improvement or micro feature and removed Regression labels Sep 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

!Improvement A functional improvement or micro feature Skanetrafiken On skanetrafikens roadmap

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Consider wheelchair access on boarding/alightning

5 participants