Fallback to recorded/expected arrival/departure time if other one is missing in SIRI-ET#4055
Merged
Merged
Conversation
hannesj
added
Entur Test
Member
|
Also discussed in #3962. Is it a good idea to improve the test coverage of |
hannesj
marked this pull request as draft
April 5, 2022 08:46
hannesj
force-pushed
the
otp2_netex_use_fallback
branch
from
April 22, 2022 10:03
3df153c to
51727d6
Compare
Closed
hannesj
force-pushed
the
otp2_netex_use_fallback
branch
from
May 10, 2022 12:00
51727d6 to
8b14c02
Compare
hannesj
marked this pull request as ready for review
May 10, 2022 12:13
lassetyr
previously approved these changes
May 10, 2022
Bartosz-Kruba
suggested changes
May 10, 2022
Co-authored-by: Bartosz-Kruba <98400292+Bartosz-Kruba@users.noreply.github.com>
Bartosz-Kruba
approved these changes
May 10, 2022
lassetyr
approved these changes
May 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Currently we get a lot of non-increasing times due to either the bus leaving before it's assigned time or being expected to arrive late at the final stop. This is due to either recorded or expected arrival or departure time being missing, so that the scheduled time is used instead. Instead we should use the actual or expected departure or arrival time to fill in the missing time.