Fix problem with submode filter - #4093
Merged
Bartosz-Kruba merged 2 commits intoApr 20, 2022
Merged
Conversation
Bartosz-Kruba
force-pushed
the
submode_filter
branch
from
April 13, 2022 11:29
9e9237d to
8d669b7
Compare
- Ensure that UNKNOWN submode matches on null.
| boolean submodeMatch = | ||
| subMode == null || | ||
| subMode.equals(netexSubMode) || | ||
| (subMode.equals("unknown") && netexSubMode == null); |
Member
There was a problem hiding this comment.
Can you please move the string "unknown" into a constant?
leonardehrenfried
requested changes
Apr 13, 2022
leonardehrenfried
left a comment
leonardehrenfried
left a comment
Member
There was a problem hiding this comment.
Would it not be really easy to add a test for AllowedTransitMode?
- Ensure that UNKNOWN submode matches on null.
Contributor
Author
I've added some tests now |
leonardehrenfried
approved these changes
Apr 19, 2022
Contributor
|
Should we always allow for null submodes, even when a submode is set in the request, and not only when supplying unknown? |
hannesj
approved these changes
Apr 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ensure that Transmodel GraphQL UNKNOWN submode matches on nulls as well. This is needed to ensure that filter works with GTFS data.
Issue
GTFS trips does always have netex submode that is null. This means that no matter which submode filter we set, those trips will always be filtered out (there will be no match on null).
Unit tests
Created some tests for AllowedTransitMode class
Code style
Formatted with maven plugin
Documentation
No new documentation added.