Skip to content

Siri updaters for Azure ServiceBus#4106

Merged
Bartosz-Kruba merged 10 commits into
opentripplanner:dev-2.xfrom
Skanetrafiken:azure_service_bus_updater
May 5, 2022
Merged

Siri updaters for Azure ServiceBus#4106
Bartosz-Kruba merged 10 commits into
opentripplanner:dev-2.xfrom
Skanetrafiken:azure_service_bus_updater

Conversation

@Bartosz-Kruba
Copy link
Copy Markdown
Contributor

@Bartosz-Kruba Bartosz-Kruba commented Apr 21, 2022

Summary

Siri ET and SX updaters that allow OTP to connect to Azure Service Bus. There's implementation for fetching from "history" endpoint as well so that old messages can be fetched. We are using those updaters at Skånetrafiken to fetch realtime data.

Issue

n/a

Unit tests

No new unit tests.

Code style

Formtted with maven plugin.

Documentation

Added json example how the updaters should configured.

@Bartosz-Kruba Bartosz-Kruba requested a review from a team as a code owner April 21, 2022 13:11
@t2gran t2gran added this to the 2.2 milestone Apr 21, 2022
@t2gran t2gran added !Improvement A functional improvement or micro feature +Sandbox This will be implemented as a Sandbox feature labels Apr 21, 2022
@leonardehrenfried
Copy link
Copy Markdown
Member

If you want to encourage Azure usage by other orgs then you could put complete config files in docs/examples. Not a requirement to get this merged.

Comment thread src/ext/java/org/opentripplanner/ext/siri/updater/TransitAlertProvider.java Outdated
Copy link
Copy Markdown
Member

@leonardehrenfried leonardehrenfried left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would move the new interface into the core but I think we want to hear other people's opinion on this.

@MikaelJarfors MikaelJarfors added the Skanetrafiken On skanetrafikens roadmap label Apr 22, 2022
Comment thread src/main/java/org/opentripplanner/util/OTPFeature.java
@Bartosz-Kruba
Copy link
Copy Markdown
Contributor Author

If you want to encourage Azure usage by other orgs then you could put complete config files in docs/examples. Not a requirement to get this merged.

I've added some extra documentation now.

Copy link
Copy Markdown
Member

@leonardehrenfried leonardehrenfried left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot say anything about the Siri or Azure part but from a core perspective this looks well separated and doesn't seem to interfere with the rest of the system.

hannesj
hannesj previously approved these changes Apr 26, 2022
Comment thread docs/examples/skanetrafiken/Readme.md Outdated
Comment thread docs/examples/skanetrafiken/Readme.md Outdated
Comment thread docs/examples/skanetrafiken/Readme.md Outdated
Comment thread docs/examples/skanetrafiken/Readme.md Outdated
Bartosz-Kruba and others added 5 commits April 29, 2022 15:18
Siri ET and SX updaters that allow OTP to connect to Azure Service Bus. There's implementation for fetching from "history" endpoint as well so that old messages can be fetched.
@Bartosz-Kruba Bartosz-Kruba dismissed stale reviews from hannesj and leonardehrenfried via efefcc6 April 29, 2022 14:05
@Bartosz-Kruba Bartosz-Kruba force-pushed the azure_service_bus_updater branch from 18cdec6 to efefcc6 Compare April 29, 2022 14:05
Comment thread docs/examples/skanetrafiken/Readme.md Outdated
Comment thread docs/examples/skanetrafiken/Readme.md Outdated
Comment thread docs/examples/skanetrafiken/Readme.md Outdated
Comment thread docs/examples/skanetrafiken/Readme.md Outdated
@@ -0,0 +1,7 @@
# Siri Azure Updater

This is module developed by Skånetrafiken. It provides support for fetching SIRI SX / ET messages through
Copy link
Copy Markdown
Contributor

@hannesj hannesj May 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be linked form the top level sandbox list and contain the same sections as the other sandbox features, like changelog and contact info

@@ -0,0 +1,7 @@
# Siri Azure Updater
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file should be removed, as there is now docs/sandbox/SiriAzureUpdater.md

@Bartosz-Kruba Bartosz-Kruba merged commit f3bc2d3 into opentripplanner:dev-2.x May 5, 2022
@Bartosz-Kruba Bartosz-Kruba deleted the azure_service_bus_updater branch May 5, 2022 13:22
t2gran pushed a commit that referenced this pull request May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

!Improvement A functional improvement or micro feature +Sandbox This will be implemented as a Sandbox feature Skanetrafiken On skanetrafikens roadmap

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants