Cost-based accessibility routing for streets - #4163
Merged
leonardehrenfried merged 56 commits intoJun 15, 2022
Merged
leonardehrenfried merged 56 commits into
leonardehrenfried merged 56 commits into
Conversation
t2gran
reviewed
May 19, 2022
t2gran
requested changes
May 19, 2022
t2gran
left a comment
t2gran
left a comment
Member
There was a problem hiding this comment.
Here are some requested changes, I have only looked at a couple of classes so fare.
Is it possible to split this PR into one that have the wheelchair accessibility changes and one that adds the new Sandbox score attributes to the plan domain model.
leonardehrenfried
added
the
!Improvement
Member
Author
|
In yesterday's dev meeting we agreed that I will split up this PR into three separate ones:
|
leonardehrenfried
force-pushed
the
accessibility-score-street
branch
5 times, most recently
from
May 20, 2022 14:21
bd11a17 to
e23463a
Compare
Member
Author
|
Anything to do with the IBI accessibility score has been moved out of this PR. |
leonardehrenfried
force-pushed
the
accessibility-score-street
branch
from
May 20, 2022 14:26
e23463a to
2892ce4
Compare
t2gran
marked this pull request as draft
May 24, 2022 08:31
leonardehrenfried
force-pushed
the
accessibility-score-street
branch
from
May 24, 2022 10:16
2892ce4 to
4895973
Compare
optionsome
previously approved these changes
Jun 9, 2022
t2gran
requested changes
Jun 10, 2022
Co-authored-by: Thomas Gran <t2gran@gmail.com>
t2gran
reviewed
Jun 13, 2022
t2gran
reviewed
Jun 13, 2022
t2gran
requested changes
Jun 13, 2022
t2gran
left a comment
t2gran
left a comment
Member
There was a problem hiding this comment.
This is starting to look good now, I made a full review (all classes) this time.
leonardehrenfried
force-pushed
the
accessibility-score-street
branch
from
June 13, 2022 14:38
3de546a to
372ff68
Compare
t2gran
requested changes
Jun 13, 2022
leonardehrenfried
force-pushed
the
accessibility-score-street
branch
from
June 13, 2022 14:39
372ff68 to
c5c4c04
Compare
Co-authored-by: Thomas Gran <t2gran@gmail.com>
t2gran
approved these changes
Jun 13, 2022
optionsome
approved these changes
Jun 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Building on the work done in #4045, this PR applies the same principles to the on-street routing.
Stairs, elevators and slope now have configurable cost for wheelchair users rather than a hard rejection.
Issue
Relates to #4009
Unit tests
Lots added.
Some other Junit 4 tests where converted to Junit 5.
Documentation
Added.