Implement nearby searches for car and bicycle parking - #4165
Merged
leonardehrenfried merged 6 commits intoMay 20, 2022
Conversation
leonardehrenfried
added
!Improvement
hannesj
approved these changes
May 20, 2022
optionsome
approved these changes
May 20, 2022
optionsome
left a comment
optionsome
left a comment
Member
There was a problem hiding this comment.
Seems to work. While creating the new API, we should probably reconsider how these filters for vehicle parkings/rentals should work.
t2gran
pushed a commit
that referenced
this pull request
May 20, 2022
leonardehrenfried
added
IBI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When using the
nearestGraphQL endpointCAR_PARKandBICYCLE_PARKwas not implemented yet. This PR changes that.Other changes:
VehicleRentalStationVertextoVehicleRentalPlaceVertexBIKE_RENTtoVEHICLE_RENTbut kept it backwards-compatible in the APIPlaceAtDistancea recordIssue
Relates to #4105
Unit tests
Added.
Documentation
Changed the GraphQL docs.
/cc @miles-grant-ibigroup