Include waiting time at beginning and end in TransitGeneralizedCostFilter - #4188
Merged
Merged
Conversation
hannesj
added
!Improvement
| * <li>To set an absolute value(3000) use: {@code 3000 + 0x} | ||
| * </ul> | ||
| * The default is {@code 3600 + 2x} - 1 hours plus 2 times the lowest cost. | ||
| * The default is {@code 900 + 1.5x} - 15 minutes plus 1.5 times the lowest cost. |
Contributor
There was a problem hiding this comment.
Why are we changing default value now?
Member
There was a problem hiding this comment.
The introduction of the intervalRelaxFactor make the function work different than before, so it make sence to change the defaults as well.
t2gran
reviewed
Jun 13, 2022
t2gran
reviewed
Jun 13, 2022
Member
|
I tested this today and can confirm that it solves the problem I described at #4167 (comment)
|
hannesj
force-pushed
the
otp2_wait_time_filter
branch
from
July 26, 2022 14:09
13ad1af to
f94ed77
Compare
Codecov Report
@@ Coverage Diff @@
## dev-2.x #4188 +/- ##
=============================================
+ Coverage 57.06% 57.14% +0.07%
- Complexity 10747 10784 +37
=============================================
Files 1430 1430
Lines 58032 58116 +84
Branches 6720 6729 +9
=============================================
+ Hits 33117 33211 +94
+ Misses 22906 22895 -11
- Partials 2009 2010 +1
Continue to review full report at Codecov.
|
leonardehrenfried
previously approved these changes
Jul 27, 2022
leonardehrenfried
left a comment
leonardehrenfried
left a comment
Member
There was a problem hiding this comment.
I tested this and it indeed improves the cases where the best route is after the latest-departure-time.
Before
After
t2gran
reviewed
Jul 27, 2022
Co-authored-by: Thomas Gran <t2gran@gmail.com>
hannesj
force-pushed
the
otp2_wait_time_filter
branch
from
July 27, 2022 09:36
85c93d5 to
ea306cc
Compare
t2gran
requested changes
Jul 27, 2022
Co-authored-by: Thomas Gran <t2gran@gmail.com>
leonardehrenfried
approved these changes
Jul 27, 2022
t2gran
approved these changes
Jul 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves filtering done in TransitGeneralizedCostFilter, in order to be able to have a tighter value for the filtering function, meaning that we get less worse results close in time, but more results far away from the best itinerary.
Issue
Fixes #4167
Unit tests
Updated the test with no cost for wait time, and some cost for wait time.