Add option to discard min transfer times#4195
Merged
hannesj merged 2 commits intoJun 2, 2022
Merged
Conversation
leonardehrenfried
requested changes
Jun 2, 2022
leonardehrenfried
left a comment
Member
There was a problem hiding this comment.
I would prefer the graph builder modules to move towards immutability but if that is controversial then I'm happy to approve this.
leonardehrenfried
approved these changes
Jun 2, 2022
Codecov Report
@@ Coverage Diff @@
## dev-2.x #4195 +/- ##
==========================================
Coverage 48.91% 48.92%
+ Complexity 10021 10020 -1
==========================================
Files 1375 1375
Lines 56461 56465 +4
Branches 6567 6567
==========================================
+ Hits 27619 27623 +4
+ Misses 26827 26824 -3
- Partials 2015 2018 +3
Continue to review full report at Codecov.
|
t2gran
approved these changes
Jun 2, 2022
t2gran
pushed a commit
that referenced
this pull request
Jun 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Currently many GTFS feeds supply minimum transfer times for all stop-to-stop paris, which are due to eg ticketing constraints or to support legacy trip planning software, which doesn't utilize the street network for transfers. Some times we want to drop these and always use transfers from OSM instead. Add support for this via a build config flag.
Documentation
Updated
Changelog
The changelog file
is generated from the pull-request title, make sure the title describe the feature or issue fixed.
To exclude the PR from the changelog add
[changelog skip]in the title.