Skip to content

Add option to discard min transfer times#4195

Merged
hannesj merged 2 commits into
opentripplanner:dev-2.xfrom
entur:otp2_discard_min_transfer_time
Jun 2, 2022
Merged

Add option to discard min transfer times#4195
hannesj merged 2 commits into
opentripplanner:dev-2.xfrom
entur:otp2_discard_min_transfer_time

Conversation

@hannesj

@hannesj hannesj commented Jun 1, 2022

Copy link
Copy Markdown
Contributor

Summary

Currently many GTFS feeds supply minimum transfer times for all stop-to-stop paris, which are due to eg ticketing constraints or to support legacy trip planning software, which doesn't utilize the street network for transfers. Some times we want to drop these and always use transfers from OSM instead. Add support for this via a build config flag.

Documentation

Updated

Changelog

The changelog file
is generated from the pull-request title, make sure the title describe the feature or issue fixed.
To exclude the PR from the changelog add [changelog skip] in the title.

@hannesj hannesj added !New Feature A functional feature targeting the end user. +GTFS Related to import of GTFS data labels Jun 1, 2022
@hannesj hannesj added this to the 2.2 milestone Jun 1, 2022
@hannesj
hannesj requested a review from a team as a code owner June 1, 2022 13:38
@hannesj hannesj added the Entur Test This is currently being tested at Entur label Jun 1, 2022
Comment thread src/main/java/org/opentripplanner/graph_builder/module/GtfsModule.java Outdated
Comment thread src/main/java/org/opentripplanner/graph_builder/module/GtfsModule.java Outdated

@leonardehrenfried leonardehrenfried left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer the graph builder modules to move towards immutability but if that is controversial then I'm happy to approve this.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Merging #4195 (ba0a9ce) into dev-2.x (6c8f210) will increase coverage by 0.00%.
The diff coverage is 72.72%.

@@            Coverage Diff             @@
##             dev-2.x    #4195   +/-   ##
==========================================
  Coverage      48.91%   48.92%           
+ Complexity     10021    10020    -1     
==========================================
  Files           1375     1375           
  Lines          56461    56465    +4     
  Branches        6567     6567           
==========================================
+ Hits           27619    27623    +4     
+ Misses         26827    26824    -3     
- Partials        2015     2018    +3     
Impacted Files Coverage Δ
...rg/opentripplanner/graph_builder/GraphBuilder.java 0.00% <0.00%> (ø)
...c/main/java/org/opentripplanner/gtfs/MockGtfs.java 45.65% <ø> (ø)
...g/opentripplanner/gtfs/mapping/TransferMapper.java 60.86% <50.00%> (-0.67%) ⬇️
...entripplanner/graph_builder/module/GtfsModule.java 68.26% <100.00%> (+0.79%) ⬆️
...er/gtfs/mapping/GTFSToOtpTransitServiceMapper.java 87.34% <100.00%> (+0.16%) ⬆️
...opentripplanner/standalone/config/BuildConfig.java 86.15% <100.00%> (+0.21%) ⬆️
...ripplanner/model/transfer/ConstrainedTransfer.java 80.00% <0.00%> (-3.34%) ⬇️
...g/opentripplanner/api/parameter/QualifiedMode.java 65.78% <0.00%> (-2.64%) ⬇️
...pplanner/graph_builder/module/osm/OSMDatabase.java 76.44% <0.00%> (ø)
...aph_builder/module/OsmBoardingLocationsModule.java 71.69% <0.00%> (+3.77%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c8f210...ba0a9ce. Read the comment docs.

@hannesj
hannesj merged commit db62a3e into opentripplanner:dev-2.x Jun 2, 2022
@hannesj
hannesj deleted the otp2_discard_min_transfer_time branch June 2, 2022 14:46
t2gran pushed a commit that referenced this pull request Jun 2, 2022
@t2gran t2gran added +Skip Changelog This is not a relevant change for a product owner since last release. and removed +Skip Changelog This is not a relevant change for a product owner since last release. labels Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Entur Test This is currently being tested at Entur +GTFS Related to import of GTFS data !New Feature A functional feature targeting the end user.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants