Skip to content

Expose SIRI ET PredictionInaccurate in Transmodel-API - #4217

Merged
t2gran merged 2 commits into
opentripplanner:dev-2.xfrom
entur:expose_siri_prediction_inaccurate
Jun 15, 2022
Merged

t2gran merged 2 commits into
opentripplanner:dev-2.xfrom
entur:expose_siri_prediction_inaccurate

Conversation

@lassetyr

Copy link
Copy Markdown
Contributor

Summary

Exposes the attribute PredictionInaccurate from SIRI ET in the TransmodelAPI

@lassetyr
lassetyr requested a review from a team as a code owner June 14, 2022 08:54
@lassetyr lassetyr added the +Real-Time The issue/PR is related to RealTime updates label Jun 14, 2022
@leonardehrenfried

Copy link
Copy Markdown
Member

You need to format the code with mvn prettier:write.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Merging #4217 (c02e382) into dev-2.x (5338b1e) will increase coverage by 7.15%.
The diff coverage is 83.33%.

@@              Coverage Diff              @@
##             dev-2.x    #4217      +/-   ##
=============================================
+ Coverage      48.93%   56.09%   +7.15%     
- Complexity     10046    10140      +94     
=============================================
  Files           1377     1377              
  Lines          56551    56565      +14     
  Branches        6589     6588       -1     
=============================================
+ Hits           27674    31728    +4054     
+ Misses         26851    22811    -4040     
  Partials        2026     2026              
Impacted Files Coverage Δ
...java/org/opentripplanner/model/TripTimeOnDate.java 15.49% <0.00%> (-0.23%) ⬇️
...transmodelapi/model/siri/et/EstimatedCallType.java 67.33% <66.66%> (+67.33%) ⬆️
...ner/ext/transmodelapi/TransmodelGraphQLSchema.java 65.61% <100.00%> (+65.61%) ⬆️
.../routing/vehicle_parking/VehicleParkingHelper.java 96.96% <0.00%> (-3.04%) ⬇️
...a/org/opentripplanner/gtfs/mapping/StopMapper.java 88.23% <0.00%> (-0.96%) ⬇️
...va/org/opentripplanner/util/TranslationHelper.java 88.23% <0.00%> (+0.28%) ⬆️
...lanner/routing/vehicle_parking/VehicleParking.java 82.81% <0.00%> (+0.78%) ⬆️
...g/opentripplanner/api/parameter/QualifiedMode.java 68.42% <0.00%> (+2.63%) ⬆️
...pplanner/routing/api/request/RequestFunctions.java 72.72% <0.00%> (+9.09%) ⬆️
...er/ext/transmodelapi/model/TransportModeSlack.java 90.32% <0.00%> (+14.51%) ⬆️
... and 59 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 080b190...c02e382. Read the comment docs.

@t2gran
t2gran merged commit ee93447 into opentripplanner:dev-2.x Jun 15, 2022
@t2gran
t2gran deleted the expose_siri_prediction_inaccurate branch June 15, 2022 15:31
t2gran pushed a commit that referenced this pull request Jun 15, 2022
@t2gran t2gran added this to the 2.2 milestone Jun 15, 2022
@t2gran t2gran added the +Sandbox This will be implemented as a Sandbox feature label Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

+Real-Time The issue/PR is related to RealTime updates +Sandbox This will be implemented as a Sandbox feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants