Do not apply walkable area processing to open platform geometries - #4225
Merged
vesameskanen merged 5 commits intoJun 22, 2022
Merged
Conversation
Area processing may remove the open geometry, leaving gaps to the graph
hannesj
previously approved these changes
Jun 20, 2022
…Database.java Co-authored-by: Leonard Ehrenfried <mail@leonard.io>
leonardehrenfried
previously approved these changes
Jun 20, 2022
Codecov Report
@@ Coverage Diff @@
## dev-2.x #4225 +/- ##
=============================================
- Coverage 56.45% 56.44% -0.01%
- Complexity 10342 10347 +5
=============================================
Files 1385 1385
Lines 56791 56810 +19
Branches 6620 6626 +6
=============================================
+ Hits 32061 32068 +7
- Misses 22728 22738 +10
- Partials 2002 2004 +2
Continue to review full report at Codecov.
|
hannesj
previously approved these changes
Jun 20, 2022
t2gran
requested changes
Jun 20, 2022
vesameskanen
dismissed stale reviews from hannesj and leonardehrenfried
via
June 21, 2022 06:53
8b489ce
leonardehrenfried
approved these changes
Jun 21, 2022
hannesj
approved these changes
Jun 21, 2022
t2gran
approved these changes
Jun 21, 2022
t2gran
pushed a commit
that referenced
this pull request
Jun 22, 2022
mvanlaar
pushed a commit
to ColombiaTransit/OpenTripPlanner
that referenced
this pull request
Jun 22, 2022
…pen-platforms" This reverts commit 8365e04.
mvanlaar
pushed a commit
to ColombiaTransit/OpenTripPlanner
that referenced
this pull request
Jun 22, 2022
This reverts commit 2b132bc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Do not assume that all platform tagged OSM ways define a closed area. Instead, add open ways to street graph as normal routable ways.
Issue
Platform tagged ways are examined before adding them to walkable area collection. If the first and last node reference differ, area processing will not be applied.
For example, Helsinki region data contains about 1000 platforms which are not explicitly tagged as areas. Only 200 of these are actually closed polygons. The rest 800 were treated as walkable areas and most likely got erased from the street graph.
3242 edges more got added to the graph.
Fixes #4215
Unit tests
Portland test data related snapshots and one OSM graph size assertion were updated. This PR adds a considerable number of edges to the Portland graph:
Documentation
Code changes include comments.