Add field 'routingErrors' to LegacyGraphQLAPI - #4253
Merged
hannesj merged 4 commits intoJul 7, 2022
Conversation
hannesj
reviewed
Jul 5, 2022
leonardehrenfried
requested changes
Jul 5, 2022
leonardehrenfried
left a comment
Member
There was a problem hiding this comment.
Use upper case for enums.
hannesj
approved these changes
Jul 7, 2022
Codecov Report
@@ Coverage Diff @@
## dev-2.x #4253 +/- ##
=============================================
+ Coverage 56.85% 56.88% +0.02%
- Complexity 10587 10591 +4
=============================================
Files 1402 1405 +3
Lines 57310 57287 -23
Branches 6649 6619 -30
=============================================
+ Hits 32585 32587 +2
+ Misses 22703 22696 -7
+ Partials 2022 2004 -18
Continue to review full report at Codecov.
|
leonardehrenfried
approved these changes
Jul 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
With current errors given by LegacyGraphQLAPI, it's not possible to know if eg. geocoding issue is related to fromPlace or toPlace (or intermediate point). This PR adds list field
routingErrorsto LegacyGraphQLAPI'sPlantype as in Transmodel API.As OTP2 currently doesn't support routing via intermediate places, intermediate point errors are mapped for destination (InputField.to).
Unit tests
Documentation
schema.graphqls.