Skip to content

Add field 'routingErrors' to LegacyGraphQLAPI - #4253

Merged
hannesj merged 4 commits into
opentripplanner:dev-2.xfrom
HSLdevcom:legacygraphql-routing-errors
Jul 7, 2022
Merged

Add field 'routingErrors' to LegacyGraphQLAPI#4253
hannesj merged 4 commits into
opentripplanner:dev-2.xfrom
HSLdevcom:legacygraphql-routing-errors

Conversation

@joonaojapalo

Copy link
Copy Markdown
Contributor

Summary

With current errors given by LegacyGraphQLAPI, it's not possible to know if eg. geocoding issue is related to fromPlace or toPlace (or intermediate point). This PR adds list field routingErrors to LegacyGraphQLAPI's Plan type as in Transmodel API.

As OTP2 currently doesn't support routing via intermediate places, intermediate point errors are mapped for destination (InputField.to).

Unit tests

  • Test suite passes.

Documentation

  • Documentation from Transmodel API copied to LegacyGraphQLAPI's schema.graphqls.

@joonaojapalo
joonaojapalo requested a review from a team as a code owner July 5, 2022 13:32
Comment thread src/ext/resources/legacygraphqlapi/schema.graphqls Outdated

@leonardehrenfried leonardehrenfried left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use upper case for enums.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Merging #4253 (76e3d28) into dev-2.x (25a88c0) will increase coverage by 0.02%.
The diff coverage is 16.66%.

@@              Coverage Diff              @@
##             dev-2.x    #4253      +/-   ##
=============================================
+ Coverage      56.85%   56.88%   +0.02%     
- Complexity     10587    10591       +4     
=============================================
  Files           1402     1405       +3     
  Lines          57310    57287      -23     
  Branches        6649     6619      -30     
=============================================
+ Hits           32585    32587       +2     
+ Misses         22703    22696       -7     
+ Partials        2022     2004      -18     
Impacted Files Coverage Δ
...anner/ext/legacygraphqlapi/LegacyGraphQLUtils.java 0.00% <0.00%> (ø)
...raphqlapi/generated/LegacyGraphQLDataFetchers.java 0.00% <ø> (ø)
...legacygraphqlapi/generated/LegacyGraphQLTypes.java 0.00% <0.00%> (ø)
...pi/datafetchers/LegacyGraphQLRoutingErrorImpl.java 66.66% <66.66%> (ø)
...anner/ext/legacygraphqlapi/LegacyGraphQLIndex.java 69.89% <100.00%> (+0.32%) ⬆️
...graphqlapi/datafetchers/LegacyGraphQLPlanImpl.java 31.11% <100.00%> (+1.56%) ⬆️
...a/org/opentripplanner/util/NonLocalizedString.java 64.70% <0.00%> (-5.89%) ⬇️
...anner/graph_builder/linking/FlexLocationAdder.java 69.23% <0.00%> (-5.77%) ⬇️
.../graph_builder/module/DirectTransferGenerator.java 82.89% <0.00%> (-3.78%) ⬇️
.../calendar/impl/CalendarServiceDataFactoryImpl.java 87.67% <0.00%> (-2.23%) ⬇️
... and 130 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25a88c0...76e3d28. Read the comment docs.

@hannesj
hannesj merged commit a48939b into opentripplanner:dev-2.x Jul 7, 2022
t2gran pushed a commit that referenced this pull request Jul 7, 2022
@t2gran t2gran added this to the 2.2 milestone Oct 25, 2022
@vesameskanen
vesameskanen deleted the legacygraphql-routing-errors branch August 15, 2025 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants