Skip to content

Support real-time updated wheelchair accessibility for trips#4255

Merged
flaktack merged 1 commit into
opentripplanner:dev-2.xfrom
realCity:feature/rt-wheelchair-accessibility
Jul 26, 2022
Merged

Support real-time updated wheelchair accessibility for trips#4255
flaktack merged 1 commit into
opentripplanner:dev-2.xfrom
realCity:feature/rt-wheelchair-accessibility

Conversation

@flaktack

@flaktack flaktack commented Jul 6, 2022

Copy link
Copy Markdown
Contributor

Summary

This allows the wheelchair accessibility of trips to be updated using GTFS-realtime. To do so the wheelchair accessibility information is added to TripTimes.

The proto changes are proposed in google/transit#340

BKK (Budapest, Hungary) has a GTFS-realtime TripUpdates feed which includes these values (txt / pb)

Issue

closes #4252

Unit tests

The existing filtering unit tests are updated.

Documentation

No changes.

@flaktack flaktack requested a review from a team as a code owner July 6, 2022 08:31
@flaktack flaktack force-pushed the feature/rt-wheelchair-accessibility branch from 672cba9 to 01330dc Compare July 6, 2022 08:36
Comment thread src/main/proto/gtfs-realtime.proto
hannesj
hannesj previously approved these changes Jul 12, 2022
@leonardehrenfried

Copy link
Copy Markdown
Member

Can you also update the value used in the cost-based wheelchair routing?

@leonardehrenfried leonardehrenfried left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please take the cost-based routing into account.

@t2gran t2gran added this to the 2.2 milestone Jul 14, 2022
@flaktack flaktack force-pushed the feature/rt-wheelchair-accessibility branch from 01330dc to ed408e9 Compare July 25, 2022 08:30

@leonardehrenfried leonardehrenfried left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also update the value used in the cost-based wheelchair routing?

@flaktack

Copy link
Copy Markdown
Contributor Author

Can you also update the value used in the cost-based wheelchair routing?

This should already be handled -- which code path have I missed?

The linked code calls:

public WheelchairAccessibility wheelchairBoardingForTrip(int index) {
return wheelchairBoardings[index];
}

Which is filled-up per-request in the constructor using TripTimes:

for (var trip : tripPatternForDates.get(d).tripTimes()) {
wheelchairBoardings[i] = trip.getWheelchairAccessibility();

@leonardehrenfried leonardehrenfried left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit stupid. Sorry for the confusion.

@flaktack flaktack changed the title Add support for real-time updated wheelchair accessibility for trips Support for real-time updated trip wheelchair accessibility Jul 26, 2022
@flaktack flaktack changed the title Support for real-time updated trip wheelchair accessibility Support real-time updated wheelchair accessibility for trips Jul 26, 2022
@flaktack flaktack merged commit 87e8061 into opentripplanner:dev-2.x Jul 26, 2022
@flaktack flaktack deleted the feature/rt-wheelchair-accessibility branch July 26, 2022 07:21
t2gran pushed a commit that referenced this pull request Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for real-time updated trip wheelchair accessibility

4 participants