Support real-time updated wheelchair accessibility for trips#4255
Merged
flaktack merged 1 commit intoJul 26, 2022
Merged
Conversation
672cba9 to
01330dc
Compare
hannesj
reviewed
Jul 6, 2022
hannesj
previously approved these changes
Jul 12, 2022
Member
|
Can you also update the value used in the cost-based wheelchair routing? |
leonardehrenfried
requested changes
Jul 13, 2022
leonardehrenfried
left a comment
Member
There was a problem hiding this comment.
Please take the cost-based routing into account.
01330dc to
ed408e9
Compare
hannesj
approved these changes
Jul 25, 2022
leonardehrenfried
requested changes
Jul 25, 2022
leonardehrenfried
left a comment
Member
There was a problem hiding this comment.
Can you also update the value used in the cost-based wheelchair routing?
Contributor
Author
This should already be handled -- which code path have I missed? The linked code calls: Which is filled-up per-request in the constructor using |
leonardehrenfried
approved these changes
Jul 26, 2022
leonardehrenfried
left a comment
Member
There was a problem hiding this comment.
I'm a bit stupid. Sorry for the confusion.
t2gran
pushed a commit
that referenced
this pull request
Jul 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This allows the wheelchair accessibility of trips to be updated using GTFS-realtime. To do so the wheelchair accessibility information is added to
TripTimes.The proto changes are proposed in google/transit#340
BKK (Budapest, Hungary) has a GTFS-realtime TripUpdates feed which includes these values (txt / pb)
Issue
closes #4252
Unit tests
The existing filtering unit tests are updated.
Documentation
No changes.