Repository navigation
Re-add block-based interlining - #4264
Merged
leonardehrenfried merged 16 commits intoJul 13, 2022
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #4264 +/- ##
=============================================
+ Coverage 56.89% 56.96% +0.07%
- Complexity 10586 10603 +17
=============================================
Files 1402 1404 +2
Lines 57170 57213 +43
Branches 6603 6604 +1
=============================================
+ Hits 32526 32591 +65
+ Misses 22630 22621 -9
+ Partials 2014 2001 -13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
leonardehrenfried
added
+GTFS
leonardehrenfried
force-pushed
the
interlining
branch
from
July 12, 2022 09:03
b775f61 to
fe0aa17
Compare
hannesj
reviewed
Jul 12, 2022
hannesj
reviewed
Jul 12, 2022
hannesj
reviewed
Jul 12, 2022
Co-authored-by: Hannes Junnila <hannes.junnila@gmail.com>
leonardehrenfried
force-pushed
the
interlining
branch
from
July 12, 2022 14:44
9c34bc1 to
6414dbb
Compare
Member
Author
|
Sorry @hannesj, I accidentally rebase after your review. :( |
optionsome
reviewed
Jul 12, 2022
optionsome
left a comment
optionsome
left a comment
Member
There was a problem hiding this comment.
Tested and it seemed to work.
optionsome
previously approved these changes
Jul 13, 2022
hannesj
suggested changes
Jul 13, 2022
Co-authored-by: Hannes Junnila <hannes.junnila@gmail.com>
hannesj
approved these changes
Jul 13, 2022
optionsome
approved these changes
Jul 13, 2022
t2gran
pushed a commit
that referenced
this pull request
Jul 13, 2022
t2gran
added
!New Feature
aaronbrethorst
pushed a commit
to OneBusAway/wayfinder
that referenced
this pull request
Mar 26, 2026
* Show a badge and indicate if the rider stays in-seat, and the stop is only interlining bus number changes * Uses OTP 2.2.0 "Re-add block-based interlining [#4264](opentripplanner/OpenTripPlanner#4264)" * https://docs.opentripplanner.org/en/latest/Changelog/?h=interlining#notable-changes_7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Re-implements the block-based interlining from OTP1.
It does so by splitting
GeometryAndBlockProcessorinto smaller pieces, one for the geometries and one for the interlining.Issue
n/a
Unit tests
Unit and integration tests added.
I removed the tests from
GeometryAndBlockProcessorTestthat were supposed to be, according to #4105.Documentation
n/a