Skip to content

Fix inconsistent mapping of NeTEx quay publicCode#4282

Merged
hannesj merged 1 commit into
opentripplanner:dev-2.xfrom
entur:otp2_netex_public_code
Jul 19, 2022
Merged

Fix inconsistent mapping of NeTEx quay publicCode#4282
hannesj merged 1 commit into
opentripplanner:dev-2.xfrom
entur:otp2_netex_public_code

Conversation

@hannesj

@hannesj hannesj commented Jul 19, 2022

Copy link
Copy Markdown
Contributor

Summary

Currently the NeTEx publicCode is mapped to the stop's code. The value is the platform number, and should be mapped to platformCode instead.

Issue

Closes #3141

@hannesj hannesj added !Bug Apply to issues describing a bug and PRs witch fixes it. +NeTEx This issue is related to the Netex model/import. labels Jul 19, 2022
@hannesj hannesj added this to the 2.2 milestone Jul 19, 2022
@hannesj hannesj requested a review from a team as a code owner July 19, 2022 11:48
@codecov-commenter

codecov-commenter commented Jul 19, 2022

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.94%. Comparing base (a00b5b3) to head (8a3b289).
⚠️ Report is 16404 commits behind head on dev-2.x.

Additional details and impacted files
@@              Coverage Diff              @@
##             dev-2.x    #4282      +/-   ##
=============================================
- Coverage      56.95%   56.94%   -0.01%     
- Complexity     10631    10636       +5     
=============================================
  Files           1414     1415       +1     
  Lines          57373    57421      +48     
  Branches        6623     6624       +1     
=============================================
+ Hits           32674    32697      +23     
- Misses         22701    22730      +29     
+ Partials        1998     1994       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@hannesj hannesj merged commit 7b01b1d into opentripplanner:dev-2.x Jul 19, 2022
@hannesj hannesj deleted the otp2_netex_public_code branch July 19, 2022 14:32
t2gran pushed a commit that referenced this pull request Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

!Bug Apply to issues describing a bug and PRs witch fixes it. +NeTEx This issue is related to the Netex model/import.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix inconsistent mapping of Netex Quay.publicCode

4 participants