Skip to content

Digitransit stop vector layer updates - #4404

Merged
optionsome merged 5 commits into
opentripplanner:dev-2.xfrom
HSLdevcom:vector-layer-updates
Aug 24, 2022
Merged

Digitransit stop vector layer updates#4404
optionsome merged 5 commits into
opentripplanner:dev-2.xfrom
HSLdevcom:vector-layer-updates

Conversation

@optionsome

@optionsome optionsome commented Aug 23, 2022

Copy link
Copy Markdown
Member

Summary

  • Adds routes' gtfsType to stop vector tiles so we can draw stops differently when routes with certain submodes go through them
  • Removed patterns from stop vector tiles

Issue

Sandbox changes so not needed.

Unit tests

We don't have tests for this?

Documentation

Not needed

Changelog

Updated sandbox documentation

@optionsome optionsome added !Improvement A functional improvement or micro feature +Sandbox This will be implemented as a Sandbox feature labels Aug 23, 2022
@optionsome
optionsome requested a review from a team as a code owner August 23, 2022 08:04
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Merging #4404 (0055dd1) into dev-2.x (b87792d) will decrease coverage by 0.00%.
The diff coverage is 62.50%.

@@              Coverage Diff              @@
##             dev-2.x    #4404      +/-   ##
=============================================
- Coverage      58.05%   58.05%   -0.01%     
- Complexity     11029    11032       +3     
=============================================
  Files           1454     1454              
  Lines          58687    58708      +21     
  Branches        6748     6751       +3     
=============================================
+ Hits           34068    34080      +12     
- Misses         22591    22597       +6     
- Partials        2028     2031       +3     
Impacted Files Coverage Δ
...es/layers/stops/DigitransitStopPropertyMapper.java 72.50% <62.50%> (-2.50%) ⬇️
...ipplanner/openstreetmap/OSMOpeningHoursParser.java 88.94% <0.00%> (-0.86%) ⬇️
...lanner/routing/vehicle_parking/VehicleParking.java 81.95% <0.00%> (-0.76%) ⬇️
.../graph_builder/module/osm/OpenStreetMapModule.java 84.65% <0.00%> (-0.32%) ⬇️
...pplanner/graph_builder/module/osm/OSMDatabase.java 76.23% <0.00%> (-0.06%) ⬇️
...rg/opentripplanner/common/RepeatingTimePeriod.java 0.00% <0.00%> (ø)
..._builder/module/configure/GraphBuilderModules.java 0.00% <0.00%> (ø)
...planner/transit/service/DefaultTransitService.java 32.72% <0.00%> (+0.90%) ⬆️
...tripplanner/transit/service/TransitModelIndex.java 71.29% <0.00%> (+1.85%) ⬆️
...ripplanner/model/transfer/ConstrainedTransfer.java 83.33% <0.00%> (+3.33%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

hannesj
hannesj previously approved these changes Aug 23, 2022
@optionsome
optionsome dismissed stale reviews from hannesj and leonardehrenfried via 95ea551 August 23, 2022 13:19
optionsome and others added 2 commits August 23, 2022 16:20
…DigitransitStopPropertyMapper.java

Co-authored-by: Leonard Ehrenfried <mail@leonard.io>
@optionsome
optionsome merged commit 0722e64 into opentripplanner:dev-2.x Aug 24, 2022
@optionsome
optionsome deleted the vector-layer-updates branch August 24, 2022 08:29
t2gran pushed a commit that referenced this pull request Aug 24, 2022
@t2gran t2gran added this to the 2.2 milestone Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

!Improvement A functional improvement or micro feature +Sandbox This will be implemented as a Sandbox feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants