Configure the import of OSM extracts individually

[vpaturet]

Summary

Update the OpenStreetMap graph build module to make use of feed-specific parameters for timezone and country-specific rules (WayPropertySet)

Issue

Implement issue #4418
Requires PR #4399

Unit tests

✅

Documentation

Updated graph builder configuration as requested in #4399

[codecov-commenter]

Codecov Report

Merging #4419 (2cf040c) into dev-2.x (00e710e) will decrease coverage by 0.00%.
The diff coverage is 77.14%.

@@              Coverage Diff              @@
##             dev-2.x    #4419      +/-   ##
=============================================
- Coverage      58.22%   58.21%   -0.01%     
- Complexity     11204    11205       +1     
=============================================
  Files           1480     1480              
  Lines          59131    59165      +34     
  Branches        6783     6783              
=============================================
+ Hits           34431    34445      +14     
- Misses         22644    22661      +17     
- Partials        2056     2059       +3     

Impacted Files	Coverage Δ
...anner/standalone/config/feed/OsmExtractConfig.java	100.00% <ø> (+12.50%)	⬆️
...pplanner/graph_builder/module/osm/OSMDatabase.java	77.09% <50.00%> (-0.28%)	⬇️
...ipplanner/openstreetmap/OpenStreetMapProvider.java	77.77% <64.70%> (-5.56%)	⬇️
.../graph_builder/module/osm/WalkableAreaBuilder.java	80.40% <66.66%> (-0.43%)	⬇️
.../graph_builder/module/osm/OpenStreetMapModule.java	84.17% <80.76%> (-0.48%)	⬇️
...ipplanner/openstreetmap/OSMOpeningHoursParser.java	89.10% <100.00%> (+0.16%)	⬆️
...tripplanner/openstreetmap/OpenStreetMapParser.java	96.77% <100.00%> (+0.13%)	⬆️
...entripplanner/openstreetmap/model/OSMWithTags.java	87.80% <100.00%> (-3.03%)	⬇️
...entripplanner/openstreetmap/model/OSMRelation.java	71.42% <0.00%> (-14.29%)	⬇️
...g/opentripplanner/openstreetmap/model/OSMNode.java	88.88% <0.00%> (-5.56%)	⬇️
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[vpaturet]

There are 2 street graph properties that are based on WayPropertySets and that are applied at graph-level:

• driving direction
• intersection traversal cost model
  

  OpenTripPlanner/src/main/java/org/opentripplanner/graph_builder/module/osm/OpenStreetMapModule.java

  Line 201 in 860e9b9

  graph.setDrivingDirection(wayPropertySetSource.drivingDirection());

OpenTripPlanner/src/main/java/org/opentripplanner/graph_builder/module/osm/OpenStreetMapModule.java

Line 202 in 860e9b9

graph.setIntersectionTraversalCostModel(

Driving direction does not seem to be used. Should it be removed?
Intersection traversal cost model is used in StreetEdge:

OpenTripPlanner/src/main/java/org/opentripplanner/routing/edgetype/StreetEdge.java

Line 1038 in 3cea9aa

.graph.getIntersectionTraversalModel()

Does it make sense to refactor it so that it becomes feed-specific?

[hannesj]

DrivingDirection is used in SimpleIntersectionTraversalCostModel, so it needs to be kept. For now, we could remove it from the WayPropertySets, and configure it directly on the graph level? Same with IntersectionTraversalCostModel

[vpaturet]

DrivingDirection is used in SimpleIntersectionTraversalCostModel, so it needs to be kept. For now, we could remove it from the WayPropertySets, and configure it directly on the graph level? Same with IntersectionTraversalCostModel

Ok, then the implicit assumption is that driving direction and intersection traversal cost model is uniform across all covered countries. This can be implemented as such and revisited later on.

[hannesj]

That sounds good.

[hannesj]

Rename wayPropertySet as osmTagMapping in the config, internal classes can be renamed in the future

[hannesj]

Take into account config changes in #4399

[optionsome]

Do these types of links work nicely with read the docs on http://docs.opentripplanner.org/en/latest/ ?