Skip to content

Configure the import of elevation data individually - #4423

Merged
vpaturet merged 4 commits into
opentripplanner:dev-2.xfrom
entur:otp2_override_dem_configuration
Sep 2, 2022
Merged

Configure the import of elevation data individually#4423
vpaturet merged 4 commits into
opentripplanner:dev-2.xfrom
entur:otp2_override_dem_configuration

Conversation

@vpaturet

@vpaturet vpaturet commented Aug 29, 2022

Copy link
Copy Markdown
Contributor

Summary

Update the ElevationModule graph builder module to make use of feed-specific configuration for elevation unit multiplier.

Issue

Implement issue #4422
Requires PR #4419

Unit tests

Documentation

No.

…_configuration

# Conflicts:
#	src/main/java/org/opentripplanner/standalone/config/feed/DemExtractConfig.java
@vpaturet vpaturet added +Bump Serialization Id Add this label if you want the serialization id automatically bumped after merging the PR !New Feature A functional feature targeting the end user. +Config Change This PR might require the configuration to be updated. labels Sep 2, 2022
@vpaturet
vpaturet marked this pull request as ready for review September 2, 2022 14:21
@vpaturet
vpaturet requested a review from a team as a code owner September 2, 2022 14:21
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Merging #4423 (0907953) into dev-2.x (98b6513) will decrease coverage by 0.00%.
The diff coverage is 40.00%.

@@              Coverage Diff              @@
##             dev-2.x    #4423      +/-   ##
=============================================
- Coverage      58.21%   58.20%   -0.01%     
- Complexity     11203    11205       +2     
=============================================
  Files           1480     1480              
  Lines          59165    59173       +8     
  Branches        6783     6783              
=============================================
- Hits           34443    34442       -1     
- Misses         22661    22674      +13     
+ Partials        2061     2057       -4     
Impacted Files Coverage Δ
..._builder/module/configure/GraphBuilderModules.java 0.00% <0.00%> (ø)
...builder/module/ned/NEDGridCoverageFactoryImpl.java 0.00% <0.00%> (ø)
...anner/standalone/config/feed/DemExtractConfig.java 0.00% <ø> (ø)
...nner/graph_builder/module/ned/ElevationModule.java 64.70% <100.00%> (ø)
...der/module/ned/GeotiffGridCoverageFactoryImpl.java 76.00% <100.00%> (+2.08%) ⬆️
...pplanner/graph_builder/module/osm/OSMDatabase.java 76.14% <0.00%> (-0.96%) ⬇️
...lanner/routing/vehicle_parking/VehicleParking.java 82.70% <0.00%> (+0.75%) ⬆️
...g/opentripplanner/api/parameter/QualifiedMode.java 68.42% <0.00%> (+2.63%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@vpaturet
vpaturet merged commit 7b0e7af into opentripplanner:dev-2.x Sep 2, 2022
t2gran pushed a commit that referenced this pull request Sep 2, 2022
t2gran pushed a commit that referenced this pull request Sep 2, 2022
@t2gran t2gran added this to the 2.2 milestone Oct 25, 2022
@t2gran
t2gran deleted the otp2_override_dem_configuration branch March 31, 2023 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

+Bump Serialization Id Add this label if you want the serialization id automatically bumped after merging the PR +Config Change This PR might require the configuration to be updated. !New Feature A functional feature targeting the end user.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants