Implement free transfers in GTFS Fares V2 - #4460
Merged
leonardehrenfried merged 18 commits intoSep 30, 2022
Merged
Conversation
leonardehrenfried
force-pushed
the
fares-v2
branch
from
September 21, 2022 09:42
fb0cd0b to
9bd04ea
Compare
leonardehrenfried
force-pushed
the
fares-v2
branch
from
September 21, 2022 09:49
9bd04ea to
9f0d2ab
Compare
leonardehrenfried
force-pushed
the
fares-v2
branch
from
September 21, 2022 14:55
3a52545 to
0d577d6
Compare
Codecov ReportBase: 58.55% // Head: 58.54% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #4460 +/- ##
=============================================
- Coverage 58.55% 58.54% -0.01%
- Complexity 11439 11481 +42
=============================================
Files 1512 1516 +4
Lines 60089 60272 +183
Branches 6829 6842 +13
=============================================
+ Hits 35185 35287 +102
- Misses 22836 22913 +77
- Partials 2068 2072 +4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
vesameskanen
approved these changes
Sep 29, 2022
hannesj
approved these changes
Sep 30, 2022
t2gran
pushed a commit
that referenced
this pull request
Sep 30, 2022
t2gran
pushed a commit
that referenced
this pull request
Sep 30, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
As a follow up of #4338 this PR implements the fare_transfer_rules.txt file from the recently added Fares V2 specification.
There are a couple of limitations though:
I plan on removing these limitations in the near future.
Unit tests
Added.
cc @lslangley @christrillium