Repository navigation
Remove filtering of flex patterns in NeTEX import - #4493
Merged
Merged
Conversation
Support and change in GTFS behaviour were in opentripplanner#3757
hannesj
added
!Improvement
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #4493 +/- ##
=============================================
+ Coverage 58.55% 58.60% +0.05%
- Complexity 11485 11517 +32
=============================================
Files 1515 1517 +2
Lines 60309 60536 +227
Branches 6842 6885 +43
=============================================
+ Hits 35313 35477 +164
- Misses 22928 22974 +46
- Partials 2068 2085 +17 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
leonardehrenfried
approved these changes
Oct 4, 2022
leonardehrenfried
left a comment
leonardehrenfried
left a comment
Member
There was a problem hiding this comment.
IBI ha been running with these flex stops in the trip times for many month and we have not noticed problems.
t2gran
approved these changes
Oct 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Currently we don't import
JourneyPatterns with flex stops from NeTEx files. The support for adding these, as well as the corresponding change in GTFS handling was done in #3757.