Do not run forward heuristic to calculate LAT, it is calculated from data already#4537
Merged
hannesj merged 1 commit intoNov 3, 2022
Conversation
Contributor
Author
|
Member
|
🍾 |
leonardehrenfried
approved these changes
Oct 21, 2022
t2gran
approved these changes
Nov 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Currently we run a forward heuristic search, if either EDT or LAT is not defined in the request. In #3664, we changed the behaviour, so that the reverse heuristic doesn't require the LAT to be set anymore. However, we missed changing the criteria of when the search should be done. This PR changes that, so that LAT is not required anymore when the reverse heuristic search is done. Also the
RangeRaptorDynamicSearchis fixed, as it previously expected the first search to always be the forward heuristic search.