Skip to content

Extract separate conditions for "equals", "greater than", "absent" during OSM tag mapping, add Portland tag mapping - #4593

Merged
leonardehrenfried merged 29 commits into
opentripplanner:dev-2.xfrom
ibi-group:osm-tag-operators
Dec 7, 2022
Merged

Extract separate conditions for "equals", "greater than", "absent" during OSM tag mapping, add Portland tag mapping#4593
leonardehrenfried merged 29 commits into
opentripplanner:dev-2.xfrom
ibi-group:osm-tag-operators

Conversation

@leonardehrenfried

@leonardehrenfried leonardehrenfried commented Nov 13, 2022

Copy link
Copy Markdown
Member

Summary

This is a port of the IBI walk comfort rules that they added to their 1.x fork. Since #4328 already added the walk safety as a parameter during building and routing, this only adds additional conditions so you can have more complex expressions like

  • absent
  • greater

It would be trivial to add more of these.

Lastly, I also added the tag mapping for the city of Portland (the birthplace of OTP!), which is the first user of these new features.

Issue

#3516

Implements part of #3724

Closes #2751 as it implements the Portland mapper in OTP2.

Unit tests

Lots added.

Documentation

Manually and automatically updated.

cc @demory

@codecov-commenter

codecov-commenter commented Nov 13, 2022

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 91.80328% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 60.73%. Comparing base (eb8cf1b) to head (10ed4a9).
⚠️ Report is 14515 commits behind head on dev-2.x.

Files with missing lines Patch % Lines
.../graph_builder/module/osm/specifier/Condition.java 84.90% 7 Missing and 1 partial ⚠️
...ilder/module/osm/specifier/BestMatchSpecifier.java 96.55% 0 Missing and 1 partial ⚠️
...ph_builder/module/osm/tagmapping/OsmTagMapper.java 66.66% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             dev-2.x    #4593      +/-   ##
=============================================
+ Coverage      60.70%   60.73%   +0.02%     
- Complexity     12240    12255      +15     
=============================================
  Files           1579     1586       +7     
  Lines          63414    63529     +115     
  Branches        6990     6992       +2     
=============================================
+ Hits           38498    38583      +85     
- Misses         22740    22772      +32     
+ Partials        2176     2174       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@leonardehrenfried leonardehrenfried added !New Feature A functional feature targeting the end user. IBI Developed by or important for IBI Group labels Nov 14, 2022
@demory
demory self-requested a review November 14, 2022 16:46
@demory demory self-assigned this Nov 14, 2022
@hannesj
hannesj requested a review from optionsome November 15, 2022 09:40
Comment thread doc-templates/BuildConfiguration.md Outdated
Comment thread docs/BuildConfiguration.md Outdated
optionsome
optionsome previously approved these changes Nov 21, 2022
optionsome
optionsome previously approved these changes Nov 23, 2022
optionsome
optionsome previously approved these changes Nov 29, 2022

@demory demory left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General comment: would it make sense to include a LessThan condition alongside GreaterThan even though it is not immediately needed by TriMet? Then we would have all of the conditions needed for basic numerical comparison (less, greater, equal, and the ability to combine multiple)

optionsome
optionsome previously approved these changes Nov 30, 2022
@t2gran t2gran added this to the 2.3 milestone Dec 6, 2022
@leonardehrenfried
leonardehrenfried merged commit 2c211a9 into opentripplanner:dev-2.x Dec 7, 2022
t2gran pushed a commit that referenced this pull request Dec 7, 2022
@leonardehrenfried
leonardehrenfried deleted the osm-tag-operators branch December 7, 2022 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

IBI Developed by or important for IBI Group !New Feature A functional feature targeting the end user.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants