Extract separate conditions for "equals", "greater than", "absent" during OSM tag mapping, add Portland tag mapping - #4593
Merged
leonardehrenfried merged 29 commits intoDec 7, 2022
Conversation
leonardehrenfried
force-pushed
the
osm-tag-operators
branch
from
November 13, 2022 20:51
0d5db93 to
7f64c7e
Compare
leonardehrenfried
force-pushed
the
osm-tag-operators
branch
from
November 13, 2022 20:51
7f64c7e to
1a9a00a
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #4593 +/- ##
=============================================
+ Coverage 60.70% 60.73% +0.02%
- Complexity 12240 12255 +15
=============================================
Files 1579 1586 +7
Lines 63414 63529 +115
Branches 6990 6992 +2
=============================================
+ Hits 38498 38583 +85
- Misses 22740 22772 +32
+ Partials 2176 2174 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
demory
self-requested a review
November 14, 2022 16:46
optionsome
reviewed
Nov 17, 2022
Co-authored-by: Joel Lappalainen <lappalj8@gmail.com>
leonardehrenfried
force-pushed
the
osm-tag-operators
branch
from
November 18, 2022 12:26
41d38a7 to
c1f6175
Compare
optionsome
previously approved these changes
Nov 21, 2022
optionsome
previously approved these changes
Nov 23, 2022
optionsome
previously approved these changes
Nov 29, 2022
demory
reviewed
Nov 29, 2022
demory
left a comment
Member
There was a problem hiding this comment.
General comment: would it make sense to include a LessThan condition alongside GreaterThan even though it is not immediately needed by TriMet? Then we would have all of the conditions needed for basic numerical comparison (less, greater, equal, and the ability to combine multiple)
optionsome
previously approved these changes
Nov 30, 2022
leonardehrenfried
enabled auto-merge
December 1, 2022 12:49
optionsome
approved these changes
Dec 5, 2022
demory
approved these changes
Dec 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is a port of the IBI walk comfort rules that they added to their 1.x fork. Since #4328 already added the walk safety as a parameter during building and routing, this only adds additional conditions so you can have more complex expressions like
It would be trivial to add more of these.
Lastly, I also added the tag mapping for the city of Portland (the birthplace of OTP!), which is the first user of these new features.
Issue
#3516
Implements part of #3724
Closes #2751 as it implements the Portland mapper in OTP2.
Unit tests
Lots added.
Documentation
Manually and automatically updated.
cc @demory