Make maxFlexTripDuration configurable - #4642
Merged
Merged
Conversation
hannesj
added
!New Feature
|
|
||
| Duration maxTransferDuration; | ||
|
|
||
| if (json.exist("maxTransferDurationSeconds")) { |
Member
There was a problem hiding this comment.
I'm usually with Thomas here. People are just as likely to overlook the config change when you wait so you might as well make it backwards-incompatible now.
Contributor
Author
There was a problem hiding this comment.
I will remove the compatibility
leonardehrenfried
previously approved these changes
Nov 28, 2022
leonardehrenfried
added
the
+Config Change
| }, | ||
| "flex" : { | ||
| "maxTransferDurationSeconds" : 240 | ||
| "maxTransferDuration" : "30m" |
Member
There was a problem hiding this comment.
This is an unusually long example which can make performance quite bad.
hannesj
force-pushed
the
otp2_remove_flex_params
branch
from
November 29, 2022 12:07
af70fe4 to
035526b
Compare
Also make maxFlexTripDuration configurable
hannesj
force-pushed
the
otp2_remove_flex_params
branch
from
November 29, 2022 12:37
035526b to
e21e576
Compare
hannesj
force-pushed
the
otp2_remove_flex_params
branch
from
November 29, 2022 12:38
e21e576 to
3751a23
Compare
leonardehrenfried
previously approved these changes
Nov 29, 2022
Member
|
Ah, I see the example config test is doing its job. |
leonardehrenfried
previously approved these changes
Nov 29, 2022
Codecov ReportBase: 60.70% // Head: 60.71% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #4642 +/- ##
==========================================
Coverage 60.70% 60.71%
+ Complexity 12240 12239 -1
==========================================
Files 1579 1579
Lines 63414 63431 +17
Branches 6990 6990
==========================================
+ Hits 38498 38511 +13
- Misses 22740 22743 +3
- Partials 2176 2177 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
leonardehrenfried
approved these changes
Dec 5, 2022
TimMickelsonSkanetrafiken
approved these changes
Dec 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Currently
maxFlexTripDurationis hard-coded in the flex calculator. Make it configurable from the router config.Also remove unnecessary
FlexParameters, by just usingFlexConfigwhere needed and migratemaxTransferDurationSecondsto duration-typedmaxTransferDuration