Skip to content

Add limits for flex access/egress walking - #4655

Merged
leonardehrenfried merged 11 commits into
opentripplanner:dev-2.xfrom
ibi-group:flex-access-limit
Dec 9, 2022
Merged

Add limits for flex access/egress walking#4655
leonardehrenfried merged 11 commits into
opentripplanner:dev-2.xfrom
ibi-group:flex-access-limit

Conversation

@leonardehrenfried

@leonardehrenfried leonardehrenfried commented Dec 5, 2022

Copy link
Copy Markdown
Member

This PR depends on #4642 so please review that first.

Summary

This makes the walk access and egress to a flex route configurable.

You want to configure that for two reasons:

  • Multiple, overlapping flex zones can lead to bad performance (see Washington flex speed test)
  • Some services are advertised as "driving you home" so there you don't want to see a route with a long walk

Documentation

Autogenerated.

@leonardehrenfried leonardehrenfried added +Sandbox This will be implemented as a Sandbox feature IBI Developed by or important for IBI Group labels Dec 5, 2022
@t2gran t2gran added this to the 2.3 milestone Dec 6, 2022
@leonardehrenfried
leonardehrenfried marked this pull request as ready for review December 6, 2022 15:17
@leonardehrenfried
leonardehrenfried requested a review from a team as a code owner December 6, 2022 15:17
hannesj
hannesj reviewed Dec 8, 2022
View reviewed changes
Comment thread src/main/java/org/opentripplanner/standalone/config/sandbox/FlexConfig.java Outdated
@leonardehrenfried leonardehrenfried mentioned this pull request Dec 8, 2022
Closed
hannesj
hannesj previously approved these changes Dec 8, 2022
View reviewed changes
@hannesj
hannesj requested review from vpaturet December 8, 2022 15:09
@leonardehrenfried
leonardehrenfried merged commit f28b0b9 into opentripplanner:dev-2.x Dec 9, 2022
t2gran pushed a commit that referenced this pull request Dec 9, 2022
OTP Changelog Bot
Add changelog entry for #4655 [ci skip]
7818766
@leonardehrenfried
leonardehrenfried deleted the flex-access-limit branch December 9, 2022 08:23
@leonardehrenfried leonardehrenfried added the X Bbnavi ~ Not in use any more ~ label Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vpaturet vpaturet Awaiting requested review from vpaturet
1 more reviewer
@hannesj hannesj hannesj approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

IBI Developed by or important for IBI Group +Sandbox This will be implemented as a Sandbox feature X Bbnavi ~ Not in use any more ~

Projects

None yet

Milestone

2.3

Development

Successfully merging this pull request may close these issues.

4 participants

@leonardehrenfried @hannesj @vpaturet @t2gran