Replace surface=cobblestone:flattened with surface=set as a mixin spec in default OsmTagMapper - #4683
Merged
t2gran merged 1 commit intoJan 3, 2023
Conversation
hannesj
reviewed
Dec 21, 2022
| props.setMixinProperties("surface=cobblestone", ofBicycleSafety(1.3)); | ||
| props.setMixinProperties("surface=cobblestone:flattened", ofBicycleSafety(1.3)); | ||
| props.setMixinProperties("surface=sett", ofBicycleSafety(1.3)); | ||
| props.setMixinProperties("surface=unhewn_cobblestone", ofBicycleSafety(1.5)); |
Contributor
There was a problem hiding this comment.
I think this might have an even higher safety value
Contributor
Author
There was a problem hiding this comment.
I agree. But how much? I thought that 100, like surface=sand, is a slight exaggeration.
hannesj
approved these changes
Dec 21, 2022
leonardehrenfried
changed the title
leonardehrenfried
approved these changes
Dec 21, 2022
t2gran
pushed a commit
that referenced
this pull request
Jan 3, 2023
leonardehrenfried
pushed a commit
to ibi-group/OpenTripPlanner
that referenced
this pull request
Jan 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DefaultMapper use the tag
surface=cobblestone:flattened. OpenStreetMap wiki sitessurface=cobblestone:flattenedas a possible mistagging ofsurface=sett.surface=settis used 310 650 times, whilesurface=cobblestone:flattenedis only used 5 431 times world wide.This PR suggest to replace
surface=cobblestone:flattenedwithsurface=settas a mixin spec, and to add a mixin spec forsurface=unhewn_cobblestone.Both are tags are already in use in NorwayMapper.