Skip to content

Configuration of additional HTTP headers for GTFS-RT updaters - #4684

Merged
leonardehrenfried merged 10 commits into
opentripplanner:dev-2.xfrom
ibi-group:gtfs-rt-headers
Jan 12, 2023
Merged

leonardehrenfried merged 10 commits into
opentripplanner:dev-2.xfrom
ibi-group:gtfs-rt-headers

Conversation

@leonardehrenfried

Copy link
Copy Markdown
Member

Summary

This adds configuration parameters so that HTTP headers can be configured for GTFS-RT updaters for trip updates, vehicle positions and alerts.

I've also slightly reworked how the example JSON snippets are formatted.

Issue

Closes #2544.

Unit tests

Added for MapUtils.combine.

Documentation

Autogenerated.

@leonardehrenfried leonardehrenfried added !New Feature A functional feature targeting the end user. IBI Developed by or important for IBI Group labels Dec 20, 2022
@leonardehrenfried
leonardehrenfried marked this pull request as ready for review December 20, 2022 12:18
@leonardehrenfried
leonardehrenfried requested a review from a team as a code owner December 20, 2022 12:18
@leonardehrenfried
leonardehrenfried force-pushed the gtfs-rt-headers branch 2 times, most recently from 803d68f to e74459a Compare December 20, 2022 12:21
@leonardehrenfried leonardehrenfried changed the title Configure HTTP headers for GTFS-RT updaters Configuration of HTTP headers for GTFS-RT updaters Dec 20, 2022
@leonardehrenfried leonardehrenfried changed the title Configuration of HTTP headers for GTFS-RT updaters Configuration of additional HTTP headers for GTFS-RT updaters Dec 20, 2022
@codecov

codecov Bot commented Dec 21, 2022 •

Copy link
Copy Markdown

Codecov Report

Base: 61.15% // Head: 61.41% // Increases project coverage by +0.26% 🎉

Coverage data is based on head (56edbb3) compared to base (5eb33c1).
Patch coverage: 79.45% of modified lines in pull request are covered.

Additional details and impacted files
@@              Coverage Diff              @@
##             dev-2.x    #4684      +/-   ##
=============================================
+ Coverage      61.15%   61.41%   +0.26%     
  Complexity     12437    12437              
=============================================
  Files           1597     1595       -2     
  Lines          63997    63756     -241     
  Branches        6982     6910      -72     
=============================================
+ Hits           39136    39157      +21     
+ Misses         22648    22384     -264     
- Partials        2213     2215       +2     
Impacted Files Coverage Δ
...anner/updater/alert/GtfsRealtimeAlertsUpdater.java 0.00% <0.00%> (ø)
...updater/trip/GtfsRealtimeHttpTripUpdateSource.java 0.00% <0.00%> (ø)
...ehicle_position/PollingVehiclePositionUpdater.java 0.00% <0.00%> (ø)
...ner/updater/trip/PollingTripUpdaterParameters.java 21.42% <50.00%> (-21.43%) ⬇️
...ter/alert/GtfsRealtimeAlertsUpdaterParameters.java 75.00% <66.66%> (+17.85%) ⬆️
...outerconfig/updaters/PollingTripUpdaterConfig.java 80.00% <90.00%> (+4.00%) ⬆️
...opentripplanner/framework/collection/MapUtils.java 90.90% <100.00%> (+3.40%) ⬆️
...standalone/config/routerconfig/UpdatersConfig.java 59.49% <100.00%> (+2.16%) ⬆️
...nfig/updaters/GtfsRealtimeAlertsUpdaterConfig.java 95.23% <100.00%> (+9.52%) ⬆️
...config/updaters/VehiclePositionsUpdaterConfig.java 95.45% <100.00%> (+1.33%) ⬆️
... and 12 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@t2gran
t2gran requested review from optionsome and t2gran January 3, 2023 09:31
Comment thread src/main/java/org/opentripplanner/framework/collection/MapUtils.java Outdated
optionsome
optionsome previously approved these changes Jan 9, 2023
Comment thread docs/UpdaterConfig.md Outdated
Comment thread docs/UpdaterConfig.md Outdated
Comment thread src/test/java/org/opentripplanner/generate/doc/framework/DocBuilder.java Outdated
@leonardehrenfried
leonardehrenfried merged commit 00e9408 into opentripplanner:dev-2.x Jan 12, 2023
t2gran pushed a commit that referenced this pull request Jan 12, 2023
@leonardehrenfried
leonardehrenfried deleted the gtfs-rt-headers branch January 12, 2023 14:03
leonardehrenfried pushed a commit to ibi-group/OpenTripPlanner that referenced this pull request Jan 18, 2023
@t2gran t2gran added this to the 2.3 milestone Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

IBI Developed by or important for IBI Group !New Feature A functional feature targeting the end user.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants