Skip to content

Upgrade dependencies to take newest GTFS Flex spec into account#4693

Merged
leonardehrenfried merged 4 commits into
opentripplanner:dev-2.xfrom
ibi-group:upgrade-dependencies
Jan 12, 2023
Merged

Upgrade dependencies to take newest GTFS Flex spec into account#4693
leonardehrenfried merged 4 commits into
opentripplanner:dev-2.xfrom
ibi-group:upgrade-dependencies

Conversation

@leonardehrenfried
Copy link
Copy Markdown
Member

Summary

The primary change of this PR is the upgrade of the OneBusAway GTFS import library to take into account a change in the GTFS flex: MobilityData/gtfs-flex@547200d

However, since I was working on the POM anyways, I upgraded the other libraries as well. The Jackson update fixes a security warning.

I've run this PR with IBI's smoke test suit and it passes.

cc @miles-grant-ibigroup @demory

@leonardehrenfried leonardehrenfried requested a review from a team as a code owner January 9, 2023 08:30
@leonardehrenfried leonardehrenfried added !Technical Debt Improve code quality, no functional changes. IBI Developed by or important for IBI Group labels Jan 9, 2023
@leonardehrenfried leonardehrenfried changed the title Upgrade dependencies Upgrade dependencies to take newest GTFS Flex spec into account Jan 9, 2023
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 9, 2023

Codecov Report

Base: 61.48% // Head: 61.15% // Decreases project coverage by -0.33% ⚠️

Coverage data is based on head (e46a1f5) compared to base (de93d74).
Patch has no changes to coverable lines.

❗ Current head e46a1f5 differs from pull request most recent head 4219c38. Consider uploading reports for the commit 4219c38 to get more accurate results

Additional details and impacted files
@@              Coverage Diff              @@
##             dev-2.x    #4693      +/-   ##
=============================================
- Coverage      61.48%   61.15%   -0.34%     
+ Complexity     12484    12438      -46     
=============================================
  Files           1596     1597       +1     
  Lines          63854    63998     +144     
  Branches        6921     6982      +61     
=============================================
- Hits           39260    39137     -123     
- Misses         22373    22648     +275     
+ Partials        2221     2213       -8     
Impacted Files Coverage Δ
...ipplanner/raptor/spi/RaptorTransferConstraint.java 50.00% <0.00%> (-25.00%) ⬇️
...pter/transit/request/TripScheduleAlightSearch.java 72.72% <0.00%> (-16.56%) ⬇️
.../ext/legacygraphqlapi/IntrospectionTypeWiring.java 62.06% <0.00%> (-16.37%) ⬇️
...apter/transit/request/TripScheduleBoardSearch.java 76.36% <0.00%> (-14.71%) ⬇️
.../rangeraptor/lifecycle/LifeCycleSubscriptions.java 84.37% <0.00%> (-6.25%) ⬇️
...rangeraptor/lifecycle/LifeCycleEventPublisher.java 94.44% <0.00%> (-5.56%) ⬇️
...geraptor/transit/TripScheduleExactMatchSearch.java 61.53% <0.00%> (-3.17%) ⬇️
...pplanner/raptor/rangeraptor/RangeRaptorWorker.java 98.46% <0.00%> (-1.54%) ⬇️
.../opentripplanner/ext/fares/FaresConfiguration.java 51.35% <0.00%> (-1.43%) ⬇️
...aptor/standard/configure/StdRangeRaptorConfig.java 78.82% <0.00%> (-0.96%) ⬇️
... and 39 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

hannesj
hannesj previously approved these changes Jan 9, 2023
hannesj
hannesj previously approved these changes Jan 10, 2023
@hannesj hannesj requested a review from t2gran January 10, 2023 10:26
@leonardehrenfried leonardehrenfried merged commit b965b57 into opentripplanner:dev-2.x Jan 12, 2023
t2gran pushed a commit that referenced this pull request Jan 12, 2023
@leonardehrenfried leonardehrenfried deleted the upgrade-dependencies branch January 12, 2023 13:08
leonardehrenfried pushed a commit to ibi-group/OpenTripPlanner that referenced this pull request Jan 18, 2023
@t2gran t2gran added this to the 2.3 milestone Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

IBI Developed by or important for IBI Group !Technical Debt Improve code quality, no functional changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants