Skip to content

Remove NYC fare service - #4694

Merged
leonardehrenfried merged 2 commits into
opentripplanner:dev-2.xfrom
leonardehrenfried:remove-nyc-calculator
Jan 10, 2023
Merged

leonardehrenfried merged 2 commits into
opentripplanner:dev-2.xfrom
leonardehrenfried:remove-nyc-calculator

Conversation

@leonardehrenfried

Copy link
Copy Markdown
Member

Summary

Since we cannot find anyone who is using this or wants to maintain it, we will remove the fare calculator for NYC.

@leonardehrenfried leonardehrenfried added !Technical Debt Improve code quality, no functional changes. +Skip Changelog This is not a relevant change for a product owner since last release. labels Jan 9, 2023
@leonardehrenfried
leonardehrenfried requested a review from a team as a code owner January 9, 2023 10:15
@codecov

codecov Bot commented Jan 9, 2023

Copy link
Copy Markdown

Codecov Report

Base: 61.14% // Head: 61.39% // Increases project coverage by +0.25% 🎉

Coverage data is based on head (844f525) compared to base (de565e5).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@              Coverage Diff              @@
##             dev-2.x    #4694      +/-   ##
=============================================
+ Coverage      61.14%   61.39%   +0.25%     
  Complexity     12435    12435              
=============================================
  Files           1597     1595       -2     
  Lines          63998    63739     -259     
  Branches        6982     6910      -72     
=============================================
+ Hits           39134    39135       +1     
+ Misses         22649    22389     -260     
  Partials        2215     2215              
Impacted Files Coverage Δ
.../opentripplanner/ext/fares/FaresConfiguration.java 52.77% <0.00%> (+1.42%) ⬆️
...g/opentripplanner/api/parameter/QualifiedMode.java 65.78% <0.00%> (-2.64%) ⬇️
...ph_builder/module/ned/MissingElevationHandler.java 95.27% <0.00%> (+1.57%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@leonardehrenfried leonardehrenfried added +Sandbox This will be implemented as a Sandbox feature and removed +Skip Changelog This is not a relevant change for a product owner since last release. labels Jan 9, 2023
@leonardehrenfried
leonardehrenfried merged commit 0d7c0e6 into opentripplanner:dev-2.x Jan 10, 2023
t2gran pushed a commit that referenced this pull request Jan 10, 2023
@leonardehrenfried
leonardehrenfried deleted the remove-nyc-calculator branch January 10, 2023 10:33
leonardehrenfried pushed a commit to ibi-group/OpenTripPlanner that referenced this pull request Jan 18, 2023
@t2gran t2gran mentioned this pull request Feb 6, 2023
@t2gran t2gran added this to the 2.3 milestone Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

+Sandbox This will be implemented as a Sandbox feature !Technical Debt Improve code quality, no functional changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants