Skip to content

GBFS geofencing zones - part 1 - #4741

Merged
leonardehrenfried merged 32 commits into
opentripplanner:dev-2.xfrom
ibi-group:gbfs-geofencing-single-commit
Feb 2, 2023
Merged

leonardehrenfried merged 32 commits into
opentripplanner:dev-2.xfrom
ibi-group:gbfs-geofencing-single-commit

Conversation

@leonardehrenfried

@leonardehrenfried leonardehrenfried commented Jan 19, 2023 •

Copy link
Copy Markdown
Member

Summary

This implements part of the GBFS 2.1 geofencing zones specification. It is the continuation of #4680 which was bogged down in rebase/merge conflicts.

@optionsome @hannesj This one is the clean branch, which also stores the information on the vertex rather than the edge. It is ready for review.

It also adds leaving your vehicle at the edge of the rental zone and continue walking. This also works for no-drop-off zones.

However, the implementation is incomplete. The following issues exist:

  • arrive by/reverse search that finishes in a zone is not implemented

Unit tests

Lots of unit tests added and existing ones adjusted.

Documentation

Autogenerated.

Performance implications

The slowdown is very moderate (in Oslo): https://tinyurl.com/2evoymtt

From ~65ms to ~75ms.

Screenshot from 2023-01-17 13-37-07

@leonardehrenfried
leonardehrenfried requested a review from a team as a code owner January 19, 2023 20:10
@leonardehrenfried leonardehrenfried changed the title Implement forward search for GBFS geofencing Implement GBFS geofencing zones part 1 Jan 19, 2023
@leonardehrenfried leonardehrenfried added IBI Developed by or important for IBI Group +Bump Serialization Id Add this label if you want the serialization id automatically bumped after merging the PR !New Feature A functional feature targeting the end user. labels Jan 19, 2023
@leonardehrenfried leonardehrenfried changed the title Implement GBFS geofencing zones part 1 GBFS geofencing zones - part 1 Jan 19, 2023
@leonardehrenfried leonardehrenfried added this to the 2.3 milestone Jan 19, 2023
@leonardehrenfried
leonardehrenfried force-pushed the gbfs-geofencing-single-commit branch from 7c46c96 to 59994ba Compare January 19, 2023 20:23
@codecov

codecov Bot commented Jan 19, 2023 •

Copy link
Copy Markdown

Codecov Report

Base: 61.96% // Head: 61.98% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (9da98b0) compared to base (3990b47).
Patch coverage: 59.81% of modified lines in pull request are covered.

❗ Current head 9da98b0 differs from pull request most recent head 9bfc058. Consider uploading reports for the commit 9bfc058 to get more accurate results

Additional details and impacted files
@@              Coverage Diff              @@
##             dev-2.x    #4741      +/-   ##
=============================================
+ Coverage      61.96%   61.98%   +0.02%     
- Complexity     12864    12920      +56     
=============================================
  Files           1637     1644       +7     
  Lines          65251    65530     +279     
  Branches        7096     7139      +43     
=============================================
+ Hits           40431    40622     +191     
- Misses         22531    22596      +65     
- Partials        2289     2312      +23     
Impacted Files Coverage Δ
...t/smoovebikerental/SmooveBikeRentalDataSource.java 100.00% <ø> (ø)
...irectory/VehicleRentalServiceDirectoryFetcher.java 0.00% <0.00%> (ø)
...t/vilkkubikerental/VilkkuBikeRentalDataSource.java 71.05% <ø> (ø)
...api/resource/GraphInspectorVectorTileResource.java 0.00% <0.00%> (ø)
...vector/geofencing/GeofencingZonesLayerBuilder.java 0.00% <0.00%> (ø)
...ctor/geofencing/GeofencingZonesPropertyMapper.java 0.00% <0.00%> (ø)
...r/routing/vehicle_rental/VehicleRentalService.java 4.25% <ø> (ø)
...r/updater/vehicle_rental/VehicleRentalUpdater.java 0.00% <0.00%> (ø)
...al/datasources/VehicleRentalDataSourceFactory.java 0.00% <ø> (ø)
...le_rental/datasources/VehicleRentalDatasource.java 0.00% <0.00%> (ø)
... and 23 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@optionsome optionsome left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The vertex based debug layer is slightly difficult to interpret as it's not always straightforward to understand in which direction from the vertex the zone is.

Comment thread doc-templates/UpdaterConfig.md Outdated
Comment thread doc-templates/UpdaterConfig.md Outdated
Comment thread pom.xml
Comment thread src/main/java/org/opentripplanner/framework/geometry/GeometryUtils.java Outdated
Comment thread src/main/java/org/opentripplanner/street/model/edge/StreetEdge.java Outdated
Comment thread src/main/java/org/opentripplanner/street/model/vertex/TraversalExtension.java Outdated
Comment thread src/main/java/org/opentripplanner/street/model/vertex/TraversalExtension.java Outdated
Comment thread src/client/js/otp/config.js Outdated
Comment thread src/main/java/org/opentripplanner/astar/spi/AStarState.java Outdated
Comment thread doc-templates/UpdaterConfig.md Outdated
Comment thread doc-templates/UpdaterConfig.md Outdated
Comment thread doc-templates/UpdaterConfig.md Outdated
@leonardehrenfried
leonardehrenfried force-pushed the gbfs-geofencing-single-commit branch from 6d22503 to 8460430 Compare January 31, 2023 21:39
@leonardehrenfried
leonardehrenfried force-pushed the gbfs-geofencing-single-commit branch from 3486a83 to 7998add Compare February 1, 2023 10:24
@leonardehrenfried
leonardehrenfried force-pushed the gbfs-geofencing-single-commit branch from a84b88b to 58ef2dc Compare February 1, 2023 11:13
@leonardehrenfried
leonardehrenfried force-pushed the gbfs-geofencing-single-commit branch from 58ef2dc to fb1db14 Compare February 1, 2023 11:31
@leonardehrenfried
leonardehrenfried force-pushed the gbfs-geofencing-single-commit branch from 9da98b0 to 9bfc058 Compare February 2, 2023 11:25
@leonardehrenfried
leonardehrenfried merged commit b598cd6 into opentripplanner:dev-2.x Feb 2, 2023
t2gran pushed a commit that referenced this pull request Feb 2, 2023
@leonardehrenfried
leonardehrenfried deleted the gbfs-geofencing-single-commit branch February 2, 2023 12:25
t2gran pushed a commit that referenced this pull request Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

+Bump Serialization Id Add this label if you want the serialization id automatically bumped after merging the PR IBI Developed by or important for IBI Group !New Feature A functional feature targeting the end user.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants