Repository navigation
GBFS geofencing zones - part 1 - #4741
leonardehrenfried merged 32 commits into
Conversation
7c46c96 to
59994ba
Compare
Codecov ReportBase: 61.96% // Head: 61.98% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #4741 +/- ##
=============================================
+ Coverage 61.96% 61.98% +0.02%
- Complexity 12864 12920 +56
=============================================
Files 1637 1644 +7
Lines 65251 65530 +279
Branches 7096 7139 +43
=============================================
+ Hits 40431 40622 +191
- Misses 22531 22596 +65
- Partials 2289 2312 +23
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
optionsome
left a comment
There was a problem hiding this comment.
The vertex based debug layer is slightly difficult to interpret as it's not always straightforward to understand in which direction from the vertex the zone is.
Co-authored-by: Joel Lappalainen <lappalj8@gmail.com>
Co-authored-by: Joel Lappalainen <lappalj8@gmail.com>
Co-authored-by: Joel Lappalainen <lappalj8@gmail.com>
Co-authored-by: Hannes Junnila <hannes.junnila@gmail.com>
6d22503 to
8460430
Compare
3486a83 to
7998add
Compare
a84b88b to
58ef2dc
Compare
58ef2dc to
fb1db14
Compare
9da98b0 to
9bfc058
Compare
Summary
This implements part of the GBFS 2.1 geofencing zones specification. It is the continuation of #4680 which was bogged down in rebase/merge conflicts.
@optionsome @hannesj This one is the clean branch, which also stores the information on the vertex rather than the edge. It is ready for review.
It also adds leaving your vehicle at the edge of the rental zone and continue walking. This also works for no-drop-off zones.
However, the implementation is incomplete. The following issues exist:
Unit tests
Lots of unit tests added and existing ones adjusted.
Documentation
Autogenerated.
Performance implications
The slowdown is very moderate (in Oslo): https://tinyurl.com/2evoymtt
From ~65ms to ~75ms.