Do not return a leg from a leg reference, if trip does not exist on date#4758
Merged
hannesj merged 1 commit intoJan 26, 2023
Merged
Conversation
Codecov ReportBase: 61.83% // Head: 61.83% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #4758 +/- ##
=============================================
- Coverage 61.83% 61.83% -0.01%
Complexity 12713 12713
=============================================
Files 1612 1612
Lines 64614 64618 +4
Branches 7019 7020 +1
=============================================
+ Hits 39953 39955 +2
- Misses 22410 22411 +1
- Partials 2251 2252 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
leonardehrenfried
approved these changes
Jan 23, 2023
Bartosz-Kruba
approved these changes
Jan 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Currently we return a leg from a leg reference irrespective of whether the trip is actually running on the date in the reference. Check this when reconstructing the leg and return null, if the trip is not in service on the date.
This problem occurs, when the underlying transit data changes, and a specific trip does not run anymore on the service date. This currently only affects the
legquery in the Transmodel API.