Fix direct transfer analyzer#4767
Merged
hannesj merged 2 commits intoJan 26, 2023
Merged
Conversation
hannesj
added
!Bug
Codecov ReportBase: 61.86% // Head: 61.91% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #4767 +/- ##
=============================================
+ Coverage 61.86% 61.91% +0.05%
- Complexity 12770 12820 +50
=============================================
Files 1614 1618 +4
Lines 64484 64897 +413
Branches 7044 7067 +23
=============================================
+ Hits 39891 40179 +288
- Misses 22325 22444 +119
- Partials 2268 2274 +6
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
leonardehrenfried
approved these changes
Jan 26, 2023
| @Override | ||
| public int getPriority() { | ||
| return 10000000 - distance; | ||
| return -distance; |
Member
There was a problem hiding this comment.
Shouldn't have those with the highest distance also have the highest priority?
Bartosz-Kruba
approved these changes
Jan 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Direct transfer analyzer crashed if it couldn't link a stop to the street network. Fix that and add a couple of priorities to the data import issues