Skip to content

Refactor data import issue reporting#4777

Merged
vesameskanen merged 14 commits into
opentripplanner:dev-2.xfrom
HSLdevcom:issuerecords
Jan 30, 2023
Merged

Refactor data import issue reporting#4777
vesameskanen merged 14 commits into
opentripplanner:dev-2.xfrom
HSLdevcom:issuerecords

Conversation

@vesameskanen

Copy link
Copy Markdown
Contributor

Summary

Several improvements to data import issue reports:

  • Sort issue types alphabetically
  • Island pruning prefers to link with an OSM vertex sample
  • Use records, not classes, for issues. This reduces boilerplate code significantly.
  • Consistent issue structure: template strings are private, OSM links are generated the same way etc.

@vesameskanen vesameskanen requested a review from a team as a code owner January 27, 2023 14:38
@vesameskanen vesameskanen added the !Improvement A functional improvement or micro feature label Jan 27, 2023
@codecov

codecov Bot commented Jan 27, 2023

Copy link
Copy Markdown

Codecov Report

Base: 61.88% // Head: 61.86% // Decreases project coverage by -0.03% ⚠️

Coverage data is based on head (ba896bb) compared to base (78f763a).
Patch coverage: 43.67% of modified lines in pull request are covered.

Additional details and impacted files
@@              Coverage Diff              @@
##             dev-2.x    #4777      +/-   ##
=============================================
- Coverage      61.88%   61.86%   -0.03%     
- Complexity     12821    12825       +4     
=============================================
  Files           1619     1622       +3     
  Lines          64903    64850      -53     
  Branches        7071     7072       +1     
=============================================
- Hits           40168    40117      -51     
+ Misses         22460    22456       -4     
- Partials        2275     2277       +2     
Impacted Files Coverage Δ
...r/ext/transferanalyzer/DirectTransferAnalyzer.java 0.00% <0.00%> (ø)
...analyzer/annotations/TransferCouldNotBeRouted.java 0.00% <0.00%> (ø)
...er/annotations/TransferRoutingDistanceTooLong.java 0.00% <0.00%> (ø)
...anner/graph_builder/issue/api/DataImportIssue.java 20.00% <ø> (ø)
...h_builder/issue/report/DataImportIssuesToHTML.java 0.00% <0.00%> (ø)
...anner/graph_builder/issues/AreaTooComplicated.java 0.00% <0.00%> (ø)
...aph_builder/issues/BogusShapeDistanceTraveled.java 0.00% <0.00%> (ø)
...anner/graph_builder/issues/BogusShapeGeometry.java 0.00% <0.00%> (ø)
...nner/graph_builder/issues/ConflictingBikeTags.java 0.00% <0.00%> (ø)
...nner/graph_builder/issues/InvalidGtfsTransfer.java 0.00% <0.00%> (ø)
... and 43 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Comment thread docs/IslandPruning.md

@leonardehrenfried leonardehrenfried left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Java code looks good - thanks!

If you could fix the indentation of the parameters list in the docs, I'm happy to approve.

@leonardehrenfried leonardehrenfried left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just checked it. It looks good.

Screenshot from 2023-01-30 13-14-34

@vesameskanen vesameskanen merged commit 2e319d4 into opentripplanner:dev-2.x Jan 30, 2023
@vesameskanen vesameskanen deleted the issuerecords branch January 30, 2023 19:08
t2gran pushed a commit that referenced this pull request Jan 30, 2023
@t2gran t2gran added this to the 2.3 milestone Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

!Improvement A functional improvement or micro feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants