Update GBFS support to v2.3 - #4809
Merged
Merged
Conversation
hannesj
added
!Technical Debt
| case CAR -> CAR; | ||
| case MOPED -> MOPED; | ||
| case SCOOTER -> SCOOTER; | ||
| case SCOOTER_STANDING -> SCOOTER_STANDING; |
Member
There was a problem hiding this comment.
I'm unsure if we need this distinction. We can discuss briefly in the meeting.
Member
|
It's kinda nice to see that the Java compiler now helps to figure out where all the places are you need to change the code when adding an enum value. |
testower
previously approved these changes
Feb 9, 2023
hannesj
force-pushed
the
otp2_gbfs_v2_3
branch
from
February 9, 2023 17:45
8cd82aa to
f830edb
Compare
Codecov ReportBase: 62.14% // Head: 62.13% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #4809 +/- ##
=============================================
- Coverage 62.14% 62.13% -0.01%
- Complexity 13000 13003 +3
=============================================
Files 1650 1650
Lines 66064 66092 +28
Branches 7184 7183 -1
=============================================
+ Hits 41055 41068 +13
- Misses 22669 22686 +17
+ Partials 2340 2338 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
hannesj
requested review from
leonardehrenfried and
testower
and removed request for
testower
February 9, 2023 19:28
leonardehrenfried
approved these changes
Feb 9, 2023
t2gran
pushed a commit
that referenced
this pull request
Feb 15, 2023
This was referenced Feb 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
We might want to include new features from GBFS v2.3, such as the return constraints later on.
Issue
Currently we are unable to parse new form factors and propulsion types introduced in GBFS v2.3