Always check allowed modes in VehicleRentalEdge

[hannesj]

Summary

Currently we do not check available types when realtimeAvailability is false. This might produce wrong results, if the form factors allowed differ between pickup and drop off.

[leonardehrenfried]

BTW, I'm experimenting with fixing these strange windows CI errors with the following commit: ibi-group@14cce41

Maybe you want to cherry-pick to see if it makes the problem go away.

[leonardehrenfried]

Since you didn't really cause this, I approve but if it's not too much to ask could you write some tests for this functionality?

[codecov]

Codecov Report

Base: 62.94% // Head: 62.94% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (560751f) compared to base (53e6645).
Patch coverage: 52.94% of modified lines in pull request are covered.

Additional details and impacted files

@@            Coverage Diff             @@
##             dev-2.x    #4810   +/-   ##
==========================================
  Coverage      62.94%   62.94%           
  Complexity     13268    13268           
==========================================
  Files           1662     1662           
  Lines          66327    66325    -2     
  Branches        7217     7216    -1     
==========================================
- Hits           41752    41751    -1     
+ Misses         22194    22193    -1     
  Partials        2381     2381           

Impacted Files	Coverage Δ
...ipplanner/street/model/edge/VehicleRentalEdge.java	70.96% <52.94%> (-0.62%)	⬇️
...r/routing/vehicle_rental/VehicleRentalVehicle.java	37.50% <0.00%> (+4.16%)	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.