Filter functionality for GroupOfLines/GroupOfRoutes + TransmodelAPI m… - #4812
Merged
Merged
Conversation
Bartosz-Kruba
force-pushed
the
gol_filter
branch
from
February 8, 2023 15:10
63efbaa to
c50c104
Compare
Member
|
This looks good. Please merge master to make the build pass. |
Bartosz-Kruba
force-pushed
the
gol_filter
branch
from
February 10, 2023 12:18
9bd915a to
21dac73
Compare
Codecov ReportBase: 62.93% // Head: 62.13% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #4812 +/- ##
=============================================
- Coverage 62.93% 62.13% -0.80%
+ Complexity 13273 13007 -266
=============================================
Files 1660 1650 -10
Lines 66310 66105 -205
Branches 7227 7190 -37
=============================================
- Hits 41733 41076 -657
- Misses 22190 22690 +500
+ Partials 2387 2339 -48
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
leonardehrenfried
previously approved these changes
Feb 13, 2023
leonardehrenfried
left a comment
leonardehrenfried
left a comment
Member
There was a problem hiding this comment.
I could only find a small typo.
hannesj
suggested changes
Feb 14, 2023
…SelectInputType.java Co-authored-by: Leonard Ehrenfried <mail@leonard.io>
leonardehrenfried
previously approved these changes
Feb 15, 2023
t2gran
added
!New Feature
added 2 commits
February 20, 2023 14:18
# Conflicts: # src/test/java/org/opentripplanner/routing/algorithm/FilterTest.java
Bartosz-Kruba
dismissed stale reviews from hannesj and leonardehrenfried
via
February 20, 2023 13:31
a31952e
hannesj
approved these changes
Feb 20, 2023
leonardehrenfried
approved these changes
Feb 21, 2023
t2gran
pushed a commit
that referenced
this pull request
Feb 21, 2023
t2gran
pushed a commit
that referenced
this pull request
Feb 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds functionality for filtering based on GroupOfRoutes. It also adds mapping for the new filter functionality to Transmodel API.
Issue
closes #4628
Unit tests
Created unit tests for new functionality
Documentation
Documented in Transmodel API