Skip to content

Unpreferred vehicle parking tags - #4873

Merged
leonardehrenfried merged 43 commits into
opentripplanner:dev-2.xfrom
mfdz:unpreferred-tags
Mar 2, 2023
Merged

Unpreferred vehicle parking tags#4873
leonardehrenfried merged 43 commits into
opentripplanner:dev-2.xfrom
mfdz:unpreferred-tags

Conversation

@leonardehrenfried

@leonardehrenfried leonardehrenfried commented Feb 23, 2023

Copy link
Copy Markdown
Member

Apparently I mistakenly deleted my old PR about vehicle parking tags and I can't reopen it, so here is the same code but in a new PR. 🤷‍♂️

It implements the latest schema changes as discussed in #4827.

Summary

Adds the ability to define preferred tags for vehicle parking via both the GraphQL API and the configuration. If a parking facility doesn't have the preferred tag a configurable cost is added.

It also folded the VehicleParkingPreferences which only contained a single boolean into the VehicleParkingRequest.

On top of that it introduces a test implementation for the routing service and the server context so that the plan query can also be unit tested.

Closes #4827

Unit tests

Added.

Documentation

Autogenerated.

@leonardehrenfried leonardehrenfried added !New Feature A functional feature targeting the end user. +Bump Serialization Id Add this label if you want the serialization id automatically bumped after merging the PR X Bbnavi ~ Not in use any more ~ labels Feb 23, 2023
@leonardehrenfried
leonardehrenfried requested a review from a team as a code owner February 23, 2023 17:39
@codecov

codecov Bot commented Feb 23, 2023

Copy link
Copy Markdown

Codecov Report

Patch coverage: 62.66% and no project coverage change

Comparison is base (8849d28) 62.96% compared to head (a0d807c) 62.96%.

Additional details and impacted files
@@            Coverage Diff             @@
##             dev-2.x    #4873   +/-   ##
==========================================
  Coverage      62.96%   62.96%           
- Complexity     13303    13314   +11     
==========================================
  Files           1667     1669    +2     
  Lines          66321    66390   +69     
  Branches        7212     7221    +9     
==========================================
+ Hits           41756    41801   +45     
- Misses         22186    22210   +24     
  Partials        2379     2379           
Impacted Files Coverage Δ
...legacygraphqlapi/generated/LegacyGraphQLTypes.java 5.40% <0.00%> (-0.16%) ⬇️
...planner/api/common/RequestToPreferencesMapper.java 80.76% <ø> (+0.21%) ⬆️
...ing/api/request/preference/RoutingPreferences.java 92.30% <ø> (-0.55%) ⬇️
...ain/java/org/opentripplanner/model/plan/Place.java 83.33% <20.00%> (+1.36%) ⬆️
...t/legacygraphqlapi/mapping/RouteRequestMapper.java 62.01% <62.01%> (ø)
...er/street/model/edge/StreetVehicleParkingLink.java 96.29% <66.66%> (-0.77%) ⬇️
...qlapi/datafetchers/LegacyGraphQLQueryTypeImpl.java 13.00% <100.00%> (-9.01%) ⬇️
...rg/opentripplanner/api/common/RoutingResource.java 69.04% <100.00%> (+0.37%) ⬆️
...ing/api/request/request/VehicleParkingRequest.java 90.00% <100.00%> (+3.33%) ⬆️
...i/request/request/filter/VehicleParkingFilter.java 100.00% <100.00%> (ø)
... and 9 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

hannesj
hannesj previously approved these changes Feb 27, 2023
Comment thread src/ext/resources/legacygraphqlapi/schema.graphqls Outdated
@leonardehrenfried
leonardehrenfried merged commit 9507d21 into opentripplanner:dev-2.x Mar 2, 2023
@leonardehrenfried
leonardehrenfried deleted the unpreferred-tags branch March 2, 2023 10:31
t2gran pushed a commit that referenced this pull request Mar 2, 2023
t2gran pushed a commit that referenced this pull request Mar 2, 2023
@t2gran t2gran added this to the 2.3 milestone Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

+Bump Serialization Id Add this label if you want the serialization id automatically bumped after merging the PR !New Feature A functional feature targeting the end user. X Bbnavi ~ Not in use any more ~

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Preferring/unpreferring vehicle parking tags

4 participants