Skip to content

Use durations for Raptor search window configuration - #4926

Merged
leonardehrenfried merged 6 commits into
opentripplanner:dev-2.xfrom
leonardehrenfried:search-window-duration
Mar 7, 2023
Merged

Use durations for Raptor search window configuration#4926
leonardehrenfried merged 6 commits into
opentripplanner:dev-2.xfrom
leonardehrenfried:search-window-duration

Conversation

@leonardehrenfried

Copy link
Copy Markdown
Member

Summary

I believe we talked about this before: we want to start using durations in configuration everywhere rather than number of seconds or minutes.

This PR gets the ball rolling by implementing this for the raptor search window configuration.

@leonardehrenfried leonardehrenfried added !Improvement A functional improvement or micro feature +Config Change This PR might require the configuration to be updated. labels Mar 3, 2023
@leonardehrenfried
leonardehrenfried requested a review from a team as a code owner March 3, 2023 09:42
@codecov

codecov Bot commented Mar 3, 2023

Copy link
Copy Markdown

Codecov Report

Patch coverage: 84.24% and project coverage change: +0.05 🎉

Comparison is base (609a71f) 62.96% compared to head (054528c) 63.01%.

Additional details and impacted files
@@              Coverage Diff              @@
##             dev-2.x    #4926      +/-   ##
=============================================
+ Coverage      62.96%   63.01%   +0.05%     
- Complexity     13312    13356      +44     
=============================================
  Files           1669     1669              
  Lines          66390    66492     +102     
  Branches        7221     7247      +26     
=============================================
+ Hits           41800    41902     +102     
+ Misses         22211    22200      -11     
- Partials        2379     2390      +11     
Impacted Files Coverage Δ
...anner/street/model/RentalRestrictionExtension.java 42.85% <ø> (ø)
...rg/opentripplanner/street/model/vertex/Vertex.java 83.80% <0.00%> (-1.63%) ⬇️
...rvice/vehiclerental/street/BusinessAreaBorder.java 50.00% <20.00%> (-12.50%) ⬇️
.../vehiclerental/street/GeofencingZoneExtension.java 55.17% <50.00%> (+21.83%) ⬆️
...opentripplanner/street/search/state/StateData.java 86.07% <50.00%> (-2.66%) ⬇️
...org/opentripplanner/street/search/state/State.java 80.74% <63.63%> (-2.08%) ⬇️
...al/street/CompositeRentalRestrictionExtension.java 58.97% <80.00%> (+3.09%) ⬆️
.../opentripplanner/street/model/edge/StreetEdge.java 87.47% <91.89%> (+0.23%) ⬆️
...raphqlapi/datafetchers/LegacyGraphQLAlertImpl.java 23.86% <100.00%> (+0.43%) ⬆️
...er/inspector/vector/VectorTileResponseFactory.java 66.66% <100.00%> (+66.66%) ⬆️
... and 17 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@leonardehrenfried
leonardehrenfried merged commit e192810 into opentripplanner:dev-2.x Mar 7, 2023
@leonardehrenfried
leonardehrenfried deleted the search-window-duration branch March 7, 2023 10:18
t2gran pushed a commit that referenced this pull request Mar 7, 2023
@t2gran t2gran added this to the 2.3 milestone Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

+Config Change This PR might require the configuration to be updated. !Improvement A functional improvement or micro feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants