Use durations for Raptor search window configuration - #4926
Merged
leonardehrenfried merged 6 commits intoMar 7, 2023
Merged
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #4926 +/- ##
=============================================
+ Coverage 62.96% 63.01% +0.05%
- Complexity 13312 13356 +44
=============================================
Files 1669 1669
Lines 66390 66492 +102
Branches 7221 7247 +26
=============================================
+ Hits 41800 41902 +102
+ Misses 22211 22200 -11
- Partials 2379 2390 +11
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
leonardehrenfried
force-pushed
the
search-window-duration
branch
from
March 3, 2023 13:25
385d345 to
83fd5dc
Compare
leonardehrenfried
force-pushed
the
search-window-duration
branch
from
March 3, 2023 13:26
83fd5dc to
054528c
Compare
t2gran
approved these changes
Mar 3, 2023
hannesj
approved these changes
Mar 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I believe we talked about this before: we want to start using durations in configuration everywhere rather than number of seconds or minutes.
This PR gets the ball rolling by implementing this for the raptor search window configuration.