Fix timeshifting of Flex ~ Walk ~ Flex paths in Raptor - #4952
Merged
Conversation
Replace with `RaptorModuleTestCase.addMinDuration("20m", 0, T00_00, T01_00)`
This also add the ability to modify the request parameters together with the test-cases. For tests with multiple request configuration this become more readable since the parameters is set together with the expected outcome. All tests are now just one line, instead of repeating the 3 same lines.
This just add two possibilities for creating the pareto-set, it does not change mc-raptor.
ALL TESTS PASS IN THIS COMMIT!
To find the AccessArrival the StopsCursor used departure-time and not arrival-time for access where no transit connection existed. This, has probably little effect up-to know, since we require at least one transit-leg. This error however cased problems in the debugger witch logged access arrival events off by the duration of the leg.
This commit revert the onBoard as a criteria for all stop arrival in MC-Raptor, and only do it in the stops reached by access or egress.
leonardehrenfried
added
!Bug
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #4952 +/- ##
=============================================
+ Coverage 62.94% 63.98% +1.03%
- Complexity 13268 13535 +267
=============================================
Files 1662 1675 +13
Lines 66327 66148 -179
Branches 7217 7131 -86
=============================================
+ Hits 41752 42325 +573
+ Misses 22194 21450 -744
+ Partials 2381 2373 -8
... and 183 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
jtorin
suggested changes
Mar 13, 2023
jtorin
left a comment
jtorin
left a comment
Contributor
There was a problem hiding this comment.
I have performed a technical review. I have not delved into neither architecture nor accuracy or coverage of tests.
jtorin
suggested changes
Mar 15, 2023
t2gran
reviewed
Mar 15, 2023
jtorin
suggested changes
Mar 15, 2023
jtorin
approved these changes
Mar 16, 2023
vpaturet
approved these changes
Mar 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
For Raptor Flex ~ Walk ~ Flex are valid paths (even though they don't make an awful lot of sense). Right now these paths throw an exception when they are time shifted.
In collaboration with @t2gran we decided that it's easier to fix the
PathBuilderrather than complicating Raptor to deal with this special case.There were also quite a bit of Raptor refactoring and bug fixing necessary to make all use cases work.
Issue
Closes #4862
Supersedes #4907
Unit tests
Added.