Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #4963 +/- ##
=============================================
- Coverage 63.88% 63.87% -0.02%
+ Complexity 13482 13474 -8
=============================================
Files 1674 1674
Lines 66111 66107 -4
Branches 7145 7151 +6
=============================================
- Hits 42235 42224 -11
- Misses 21493 21499 +6
- Partials 2383 2384 +1
... and 10 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
vpaturet
force-pushed
the
otp2_validate_wrong_number_service_link
branch
from
March 15, 2023 13:43
28c7f11 to
043ec5d
Compare
vpaturet
marked this pull request as ready for review
March 15, 2023 14:27
t2gran
approved these changes
Mar 20, 2023
jtorin
suggested changes
Mar 20, 2023
jtorin
self-requested a review
March 23, 2023 16:20
jtorin
approved these changes
Mar 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4962
This PR adds validation logic to check that the number of ServiceLinks mapped to a JourneyPattern is consistent with the number of intervals between stops in the JourneyPattern.
If the mapping is inconsistent, an issue is logged in the issue store and the graph builder falls back to generating straight-line ServiceLinks between the stops.
Note: the current mapping logic is fragile. It assumes that the position of the ServiceLink in the shape is the same as the position of the ServiceLinkInJourneyPattern element in the XML file. Instead the "order" field in the ServiceLinkInJourneyPattern should be used. This improvement is out-of-scope for this PR.
Issue
#4962
Unit tests
Added unit test.
Documentation
No